Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] _beforeToHtml DocBlock return type $this instead of string #39508

Open
2 of 5 tasks
m2-assistant bot opened this issue Dec 24, 2024 · 0 comments · May be fixed by #39490
Open
2 of 5 tasks

[Issue] _beforeToHtml DocBlock return type $this instead of string #39508

m2-assistant bot opened this issue Dec 24, 2024 · 0 comments · May be fixed by #39490
Assignees
@lucafuser
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2024

This issue is automatically created based on existing pull request: #39490: _beforeToHtml DocBlock return type $this instead of string

Description (*)

Changed _beforeToHtml DocBlock return type $this instead of string In Magento/Checkout/Block/Onepage/Success.php according to Magento/Framework/View/Element/AbstractBlock.php parent class.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P3 May be fixed according to the position in the backlog. label Dec 24, 2024
@m2-assistant m2-assistant bot linked a pull request Dec 24, 2024 that will close this issue
Open
6 tasks
@engcom-Hotel engcom-Hotel moved this to Ready for Development in Low Priority Backlog Feb 24, 2025
@engcom-November engcom-November added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucafuser lucafuser

Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Low Priority Backlog
Status: Ready for Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

_beforeToHtml DocBlock return type $this instead of string lucafuser/magento2
2 participants
@lucafuser @engcom-November