Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate cache fpc for same page with same query #38269

Open
5 tasks
rogerdz opened this issue Dec 12, 2023 · 8 comments · May be fixed by #38270
Open
5 tasks

Duplicate cache fpc for same page with same query #38269

rogerdz opened this issue Dec 12, 2023 · 8 comments · May be fixed by #38270
Assignees
Labels
Area: Catalog Component: Cache Component: Framework/Cache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@rogerdz
Copy link
Contributor

rogerdz commented Dec 12, 2023

Preconditions and environment

  • Magento version 2.4-develop + sameple data
  • Use developer mode
  • Use build in fpc

Steps to reproduce

  1. Clear cache: bin/magento cache:clean
  2. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug, it will return x-magento-cache-debug: MISS => correct
  3. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug, it will return x-magento-cache-debug: HIT => correct
  4. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?style_bags=24&activity=8' | grep -i X-Magento-Cache-Debug => it return x-magento-cache-debug: MISS => wrong
  5. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?activity=8&style_bags=24&' | grep -i X-Magento-Cache-Debug => it return x-magento-cache-debug: MISS => wrong

Expected result

https://magento2.test/gear/bags.html?style_bags=24&activity=8 and https://magento2.test/gear/bags.html?activity=8&style_bags=24 and https://magento2.test/gear/bags.html?activity=8&style_bags=24& use same fpc

Actual result

https://magento2.test/gear/bags.html?style_bags=24&activity=8 and https://magento2.test/gear/bags.html?activity=8&style_bags=24 and https://magento2.test/gear/bags.html?activity=8&style_bags=24& use difference fpc identifier => increase page cache folder size

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Dec 12, 2023

Hi @rogerdz. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@rogerdz rogerdz linked a pull request Dec 12, 2023 that will close this issue
5 tasks
@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Dec 12, 2023
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 12, 2023
@engcom-Hotel engcom-Hotel self-assigned this Dec 19, 2023
Copy link

m2-assistant bot commented Dec 19, 2023

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

@magento give me 2.4-develop instance

Copy link

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Hotel
Copy link
Contributor

Hello @rogerdz,

Thanks for the report and collaboration!

We have tried to reproduce the issue in the vanilla Magento 2.4-develop branch and the issue is reproducible for us. We have followed the below steps:

  1. Clear the cache.
  2. Send below request via curl:
curl -I --location-trusted 'http://local.magento2ce12.com/category-4/category-4-1.html?attributeset2attribute1=10&cat=26' | grep -i X-Magento-Cache-Debug

image

  1. Sending same request is returning HIT
    image

  2. Changing the request parameters like below, again returning MISS it should return HIT:

curl -I --location-trusted 'http://local.magento2ce12.com/category-4/category-4-1.html?cat=26&attributeset2attribute1=10' | grep -i X-Magento-Cache-Debug

image

Hence confirming the issue.

Thanks

@engcom-Hotel engcom-Hotel added Component: Framework/Cache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Cache Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Catalog and removed Issue: ready for confirmation labels Dec 19, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10722 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Dec 19, 2023

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: Cache Component: Framework/Cache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants