-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Transliteration table has several mistakes and more gaps, should use standard library #37802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Crissov. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Hi @engcom-Bravo. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Bravo, here is your Magento Instance: https://89f44c3f4927ae24c111b983950a3189.instances-prod.magento-community.engineering |
Hi @Crissov, Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots. Steps to reproduce
![]()
We have referred this document https://en.wikipedia.org/wiki/S as per this document ſ it should be s. Hence Confirming the issue. Thanks. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-9226 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue. |
Hi @Crissov, Thanks for your reporting and collaboration. We have tried to reproduce the issue in Latest 2.4-develop instance and the issue is still reproducible.Kindly refer the screenshots. ![]()
Hence Confirming the issue. Thanks. |
Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Once all required labels are present, please add |
❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-9226 |
1 similar comment
❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-9226 |
Preconditions and environment
Magento version 2.4-develop
Magento\Framework\Filter\Translit
related user documentation:
Steps to reproduce
ſ
(long s),þ
(thorn) andð
(eth)Expected result
In the generated URL key,
ſ
becomess
þ
becomesth
ð
becomesd
, althoughdh
and eventh
would also be acceptableActual result
ſ
becomesz
þ
becomesp
ð
is removedAdditional information
These are just some mistakes I easily spotted by looking at the file. I’m pretty sure there are also errors (or questionable choices) in the romanisation of Cyrillic, Greek, Hebrew and Devanagari. The selection of less than 500 characters to be transliterated seems very random, so people created modules to properly support languages like Romanian and Vietnamese.
Just for Japanese, magento2-jp already introduces the use of PHP’s
Transliterator
which is the right tool for the job. Its data comes from ICU which in turn uses CLDR data, both maintained by Unicode, i.e. it is as reliable as it gets (and will still be improved in the future).If
Transliterator
is not to be used for some reason, Magento should at least use the Unicode data for Latin-ASCII and …-Latn.PS: Ideally, Magento would support setting a language for a store view which would then be respected for stuff like German umlauts (
ä
→ae
) that deviates from the script default (a
) – CLDR offers de-ASCII for that, also see #23292. Administrators should also be able to opt into UTF-8 percent encoding in all cases, but let’s keep this a bug report and not a feature request.PPS: This won’t cover stuff like
½″
which would ideally becomehalf-inch
but at best will be1-2
, or0.5 cm
which would better become5mm
than0-5-cm
.Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: