Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Improve Extensibility of Service URL Generation #37404

Open
4 of 5 tasks
m2-assistant bot opened this issue Apr 20, 2023 · 4 comments · May be fixed by #37403
Open
4 of 5 tasks

[Issue] Improve Extensibility of Service URL Generation #37404

m2-assistant bot opened this issue Apr 20, 2023 · 4 comments · May be fixed by #37403
Assignees
@pykettk
Labels
Area: Framework Component: Code Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2023

This issue is automatically created based on existing pull request: #37403: Improve Extensibility of Service URL Generation

Description (*)

There are some legitimate cases for wanting to customise this function. Let's encourage people to do so in a more maintainable way i.e. via plugins instead of preferences.

Fixed Issues

Manual testing scenarios (*)

  1. Create a plugin for the Magento\Store\Model\Argument\Interpreter\ServiceUrl::getServiceUrl() function
  2. Observe that the plugin code executes as expected

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Apr 20, 2023 that will close this issue
Open
6 tasks
@engcom-Bravo engcom-Bravo added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Reported on 2.4.x Indicates original Magento version for the Issue report. labels Apr 20, 2023
@m2-community-project m2-community-project bot assigned pykettk and unassigned pykettk Apr 24, 2023
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 2, 2023
@engcom-November engcom-November self-assigned this May 22, 2023
@m2-assistant
Copy link
Author

m2-assistant bot commented May 22, 2023

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hi @pykettk ,
Thank you for reporting and collaboration. Verified the behavior on Magento 2.4-develop instance and is reproducible. getServiceUrl() is to be declared as public instead of private. Hence confirming this issue.

@engcom-November engcom-November added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Code Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Framework labels May 22, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8813 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented May 22, 2023

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel moved this to Pull Request In Progress in High Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pykettk pykettk

Labels
Area: Framework Component: Code Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Extensibility of Service URL Generation pykettk/magento2
4 participants
@pykettk @engcom-Bravo @engcom-November @github-jira-sync-bot