-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magento 2.3.5-p2 Paypal Recaptcha does not detect scope #36161
Comments
Hi @nbennett25. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Dash. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Dash, here is your Magento Instance: https://cadcdc6c4cf55cec4d760aae4f0bc156.instances.magento-community.engineering |
Hi @nbennett25 , We are checking the issue in 2.4-develop instance...We are not able to reproduce the issue...because we are getting expected result....the Captcha in PayfloPro payment method is hidden Steps We follwed by: Thanks!!! |
@engcom-Dash can you confirm the versions of the Did you switch to the website scope in the configuration? The issue isn't that the paypal recaptcha config isn't working, it's that it's not working within the website scope (ie, change website, then set it to No while the default config is Yes) We built a patch to allow the visibility of the paypal captcha to respect the website scope, but now are seeing an error returned when trying to place an order - it looks like regardless of if the captcha is hidden, the API request to validate the captcha is being sent out (presumably with empty data) and an error is being thrown on order submission: Thanks for investigating! |
Hi @nbennett25 , Thanks for your contribution... Currently we are supporting with 2.4 develop versions...Kindly upgrade the version.Because it's very easy to proceed to further. Thanks |
@engcom-Dash did you review my comment on 9/21? This may still be an issue with 2.4.x if the |
@magento give me 2.4-develop instance |
Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Dash, here is your Magento Instance: https://cadcdc6c4cf55cec4d760aae4f0bc156.instances.magento-community.engineering |
Hi @nbennett25 , Thanks For your information...We are worked as per your last instructions...We are able to reproduce the issue in 2.4-develop branch. in admin Panel we are getting the recaptcha options in paypal payment method form...We are attached the screenshots above for your reference. |
Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Once all required labels are present, please add |
Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Once all required labels are present, please add |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-6941 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Dash. Thank you for verifying the issue. |
❌ You don't have permission to export this issue. |
❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-6941 |
Hi @nbennett25, We have tried to reproduce the issue in Latest 2.4-develop instance and the issue is no more reproducible.Hence we are closing this issue. Thanks. |
Preconditions and environment
magento/module-paypal-recaptcha
is enabledSteps to reproduce
Expected result
Captcha in PayfloPro payment method is hidden
Actual result
Captcha in PayfloPro payment method is shown
Additional information
In v1.0.1 of
magento/module-paypal-recaptcha
\Magento\PaypalReCaptcha\Model\Config::isEnabledFrontendPaypal() isreturn (bool) $this->scopeConfig->getValue(static::XML_PATH_ENABLED_FRONTEND_PAYPAL);
so it does not pass the website scope. This line should be:
return (bool) $this->scopeConfig->getValue(static::XML_PATH_ENABLED_FRONTEND_PAYPAL, \Magento\Store\Model\ScopeInterface::SCOPE_WEBSITES, $websiteId);
Where
$websiteId
is passed from the StoreManagerInterface.Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: