getItemsByColumnValue wrong type declaration #33070

vaso123 · 2021-05-25T09:52:44Z

Preconditions (*)

Magento 2.4.2

Steps to reproduce (*)

Call getItemsByColumnValue([string], [array]) on any collection.

Expected result (*)

Get the collection

Actual result (*)

Get null.

Component: magento-framework
File: vendor/magento/framework/Data/Collection.php

Description

The problem is that the input parameter $value has defined as an array in the annotation.
If you are using an array with a single value, you will get back nothing and IDEs will mark it as an error.

You should use primitives (int, string, float, etc...).

The problem is that you defined the function like this:

/**
* @param string $column
* @param array $value
* @return array
*/
public function getItemsByColumnValue($column, $value)

but later you says:

if ($item->getData($column) == $value) {

So the value should be a primitive type, not an array.

Please fix it.

Issue: Confirmed

The text was updated successfully, but these errors were encountered:

m2-assistant · 2021-05-25T09:52:45Z

Hi @vaso123. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant · 2021-05-26T03:56:30Z

Hi @engcom-Golf. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.

vaso123 · 2021-05-26T04:17:18Z

Please check it now.

magento-engcom-team · 2021-05-31T08:49:15Z

@engcom-Golf Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

Add "Reproduced on " label(s) to this ticket based on verification result