-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable captcha storefont config still load captcha js files #32987
Comments
Hi @ia-gaurav. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi i'm not sure how do you disable captcha module since this module dependency magento checkout. If completely disable module may break checkout function. The safe way to disable use config in backend instead disable complete captcha https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Captcha/etc/module.xml Any use-cases for reason disable captcha functional Extra use this module for find modules you can disable |
maybe we still have issue and now is time for investigate more on that |
This is incorrect, the dependency works the other way, it means: disabling the checkout may break the captcha module (even though this sounds unlikely). Also, the dependencies defined in the |
i donot want unwated netwrok call of Captcha when it is disabled, any way for that |
Hi @ia-gaurav Can you provide more steps for check the case unwanted load captcha after disable config from backend |
@magento give me 2.4-develop instance |
Hi @ia-gaurav. Thank you for your request. I'm working on Magento instance for you. |
Hi @ia-gaurav, here is your Magento Instance: https://782ef4132eab5e1806ada4c8d3b5d95b-2-4-develop.instances.magento-community.engineering |
See below screenshot , no captha enabled on frontend site too many unwated calls - 11 extra request of size 17.2 kB |
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Captcha/view/frontend/layout/default.xml#L17 |
Maybe js problem should report in another seperate ticket |
Hi @mrtuvn. Thank you for working on this issue.
|
ok let me update it |
Should we update title for this issue ? |
yes please do |
@mrtuvn Thank you for verifying the issue. Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:
Once all required information is added, please add label |
❌ Something went wrong. Cannot create Jira issue. |
Hi @engcom-Delta. Thank you for working on this issue.
|
Hi @ia-gaurav , Thanks for your reporting and collaboration. Steps to Reproduce
Thanks. |
❌ Something went wrong. Cannot create Jira issue. |
❌ Something went wrong. Cannot create Jira issue. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-14267 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue. |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
My expected
Actual result (*)
The text was updated successfully, but these errors were encountered: