Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable captcha storefont config still load captcha js files #32987

Open
ia-gaurav opened this issue May 10, 2021 · 30 comments · May be fixed by #39154
Open

Disable captcha storefont config still load captcha js files #32987

ia-gaurav opened this issue May 10, 2021 · 30 comments · May be fixed by #39154
Assignees
Labels
Area: Other Developer Tools Component: Captcha Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@ia-gaurav
Copy link

ia-gaurav commented May 10, 2021

Preconditions (*)

  • Magento Version - 2.4.2
  • Default Magento Theme
  • Captcha is disabled on Frontend

Steps to reproduce (*)

  • Do fresh Magento install - with or without demo Data
  • Open developer tool, goto network tab
  • Here you will see, unwanted js call for captcha
    image

Expected result (*)

  • No Captcha related scripts should be called

My expected

  • we don't need disable completely captcha module but if admin owner set config disable in backend both captcha blocks and js related may not visible in frontend

Actual result (*)

  • 11 extra request of size 17.2 kB is getting called on page
@m2-assistant
Copy link

m2-assistant bot commented May 10, 2021

Hi @ia-gaurav. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn
Copy link
Contributor

mrtuvn commented May 10, 2021

Hi i'm not sure how do you disable captcha module since this module dependency magento checkout. If completely disable module may break checkout function. The safe way to disable use config in backend instead disable complete captcha

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Captcha/etc/module.xml

Any use-cases for reason disable captcha functional

Extra use this module for find modules you can disable
https://github.com/avstudnitz/AvS_DisableModules

@ia-gaurav
Copy link
Author

yes but issue is that enabling captcha cause extra 5 unwanted request call in network even when disabled from admin

image

@mrtuvn
Copy link
Contributor

mrtuvn commented May 11, 2021

maybe we still have issue and now is time for investigate more on that

@hostep
Copy link
Contributor

hostep commented May 12, 2021

@mrtuvn:

Hi i'm not sure how do you disable captcha module since this module dependency magento checkout. If completely disable module may break checkout function.

This is incorrect, the dependency works the other way, it means: disabling the checkout may break the captcha module (even though this sounds unlikely). Also, the dependencies defined in the module.xml file are soft dependencies, so we can't really rely on that information.

@ia-gaurav
Copy link
Author

i donot want unwated netwrok call of Captcha when it is disabled, any way for that

@mrtuvn
Copy link
Contributor

mrtuvn commented May 12, 2021

Hi @ia-gaurav Can you provide more steps for check the case unwanted load captcha after disable config from backend
Pre-condition, steps, page url

@ia-gaurav
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ia-gaurav. Thank you for your request. I'm working on Magento instance for you.

@ia-gaurav
Copy link
Author

@mrtuvn

See below screenshot , no captha enabled on frontend site too many unwated calls - 11 extra request of size 17.2 kB

image

@mrtuvn
Copy link
Contributor

mrtuvn commented May 12, 2021

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Captcha/view/frontend/layout/default.xml#L17
Here is the magic happen!
No matter you enable or disable this component loginCaptcha always loaded. Other captcha files are dependencies of this
Just curious js component for checkout "path" but place in default

@mrtuvn mrtuvn added Component: Captcha Reported on 2.4.x Indicates original Magento version for the Issue report. labels May 12, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented May 13, 2021

Maybe js problem should report in another seperate ticket
May I ask you update description? Pre-condition, Steps check, expect, actually result

@mrtuvn mrtuvn self-assigned this May 13, 2021
@m2-assistant
Copy link

m2-assistant bot commented May 13, 2021

Hi @mrtuvn. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ia-gaurav
Copy link
Author

Maybe js problem should report in another seperate ticket
May I ask you update description? Pre-condition, Steps check, expect, actually result

ok let me update it

@mrtuvn
Copy link
Contributor

mrtuvn commented May 16, 2021

Should we update title for this issue ?
Example "Disable captcha storefont config still load captcha js files"
My expected we don't need disable completely captcha module but if admin owner set config disable in backend both captcha blocks and js related may not visible in frontend

@ia-gaurav
Copy link
Author

yes please do

@ia-gaurav ia-gaurav changed the title Disabling Magento_Captcha Breaks Checkout Pages Disable captcha storefont config still load captcha js files May 16, 2021
@mrtuvn mrtuvn added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 17, 2021
@magento-engcom-team
Copy link
Contributor

@mrtuvn Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 17, 2021
@mrtuvn mrtuvn added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels May 17, 2021
@github-jira-sync-bot
Copy link

❌ Something went wrong. Cannot create Jira issue.

Copy link

m2-assistant bot commented Feb 28, 2025

Hi @engcom-Delta. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Delta
Copy link
Contributor

Hi @ia-gaurav ,

Thanks for your reporting and collaboration.
We have verified the issue in latest 2.4-develop instance and the issue is reproducible.
Kindly refer the screenshots.

Steps to Reproduce

  1. Install 2.4-develop instance
  2. Disable captcha on frontend admin

Image
3. Access frontend and check network tab.
4. Observe js call for captcha is displaying

Image

Thanks.

@engcom-Delta engcom-Delta added Area: Frontend Component: Captcha Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Area: Frontend Component: Captcha Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Feb 28, 2025
@github-jira-sync-bot
Copy link

❌ Something went wrong. Cannot create Jira issue.

@engcom-Delta engcom-Delta added Area: Frontend Component: Captcha Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Frontend and removed Area: Frontend Component: Captcha Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Feb 28, 2025
@github-jira-sync-bot
Copy link

❌ Something went wrong. Cannot create Jira issue.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Area: Other Developer Tools and removed Area: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 19, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14267 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Mar 19, 2025

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Other Developer Tools Component: Captcha Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
9 participants