Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot give discount on Fixed Product Tax (WEEE) #31278

Open
kassner opened this issue Dec 14, 2020 · 17 comments
Open

Cannot give discount on Fixed Product Tax (WEEE) #31278

kassner opened this issue Dec 14, 2020 · 17 comments
Assignees
Labels
Component: Rule Component: Tax feature request Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reported on 2.4.1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@kassner
Copy link
Contributor

kassner commented Dec 14, 2020

Preconditions

  1. Magento 2.4.1, fresh install; reproducible on 2.4-develop
  2. PHP 7.4.3 (Ubuntu 20.04 LTS);

Steps to reproduce

  1. Enable the Fixed Product Tax module;

Screenshot from 2020-12-14 15-30-03

  1. Create the FPT and associate it to the default attribute set;

Screenshot from 2020-12-14 15-30-47

  1. Create a product with the FPT configured:

Screenshot from 2020-12-14 15-31-41

  1. Go to the frontend, add the product to the cart and assert that the tax is being charged (make sure to select the right country);

Screenshot from 2020-12-14 15-34-07

  1. Go back to the admin and create a 100% discount coupon code:

Screenshot from 2020-12-14 15-35-42

(Off screen: Free Shipping: For shipments with matching items).

  1. Enable the Free shipping delivery method:

Screenshot from 2020-12-14 15-38-23

  1. Go back to the frontend, to the cart, and apply your coupon;

  2. Verify that the order still has $0.99 left to be paid;

Screenshot from 2020-12-14 15-39-21

  1. Go to the checkout billing page to make sure the rule is still applicable:

Screenshot from 2020-12-14 15-40-49

Expected result

  1. Order grand total $0.00;
  2. Have a toggle in the cart rule form that allows the rule to be applied on top of the WEEE/FPT;

Actual result

  1. WEEE/FPT is charged regardless of cart rules;
  2. No way to control if WEEE/FPT should be charged regardless of the cart rule;

Additional info from Engcom

Also reproducible if Fixed amount discount for whole cart is set in Cart Price Rule Actions
fixed_ammount
Rechecked with a simple Tax Rule. The Coupon discount is applied for the whole Cart, including the Tax
The discount is not applied only for FPT

@m2-assistant
Copy link

m2-assistant bot commented Dec 14, 2020

Hi @kassner. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@kassner
Copy link
Contributor Author

kassner commented Dec 14, 2020

The Include FPT In Subtotal = Yes configuration yields the same result.

@engcom-Bravo engcom-Bravo self-assigned this Dec 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 16, 2020

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sorry, something went wrong.

@engcom-Bravo engcom-Bravo added Triage: Need PO Confirmation Requirements should be clarified/approved/confirmed with Product Manager. Not ready for fix/delivery Reported on 2.4.1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Rule Component: Tax Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Dec 16, 2020
@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Dec 16, 2020

Hello @kassner

Thank you for your report

We Confirm that the issue is reproducible on the latest 2.4-develop.
Additional info from Engcom is added to the Description

@engcom-Bravo engcom-Bravo added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 16, 2020
@m2-community-project m2-community-project bot removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: ready for confirmation labels Dec 16, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-39949 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sdzhepa
Copy link
Contributor

sdzhepa commented Dec 17, 2020

Hello @kassner
cc: @engcom-Bravo

It seems not a bug but an expected result.
FPT it's not the same as regular tax in Magento.
The main use case for this attribute(FPT) its e.g. state/country law like "all plastic or electronic stuff must have an additional $$ for recycling /utilization"
So applying a discount on FPT could violate the law

More details:

@sdzhepa sdzhepa added the Issue: needs update Additional information is require, waiting for response label Dec 17, 2020
@m2-community-project m2-community-project bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 17, 2020
@kassner
Copy link
Contributor Author

kassner commented Dec 17, 2020

@sdzhepa while I agree for some cases, this render some impossible order scenarios. Stripe, for example, requires a minimum of $0.50 in a payment, so when we try to charge $0.08 for the French WEEE tax, the customer is not able to place the order. My finance department asked me to, if the order is completely free disregarding the WEEE, do not charge it, as, technically, there isn't a sale being made.

I don't want to always apply discounts on top of the FPT, but it's important that this can be configured for the legitimate use cases.

@sdzhepa
Copy link
Contributor

sdzhepa commented Dec 17, 2020

Thank you for your feedback @kassner!

I got your point about improvement.
I will discuss it with Product Managers for the final decision(approve/reject).

@sdzhepa sdzhepa self-assigned this Dec 17, 2020
@magento magento deleted a comment from m2-assistant bot Dec 17, 2020
@m2-community-project m2-community-project bot added Issue: On Hold and removed Issue: needs update Additional information is require, waiting for response labels Dec 18, 2020
@stale
Copy link

stale bot commented Mar 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Mar 4, 2021
@kassner
Copy link
Contributor Author

kassner commented Mar 5, 2021

bump

@stale stale bot removed the stale issue label Mar 5, 2021
@sdzhepa sdzhepa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: ready for confirmation labels Jun 4, 2021
@sdzhepa sdzhepa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Jun 4, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @sdzhepa
Thank you for verifying the issue. Based on the provided information internal tickets MC-42561 were created

Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sdzhepa
Copy link
Contributor

sdzhepa commented Jun 4, 2021

reponed

Still waiting decision from Product Managers team

@sdzhepa sdzhepa added the Issue: needs update Additional information is require, waiting for response label Jun 4, 2021
@m2-community-project m2-community-project bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 4, 2021
@engcom-Echo engcom-Echo self-assigned this Jun 7, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jun 7, 2021

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sorry, something went wrong.

@engcom-Echo engcom-Echo added feature request and removed Issue: needs update Additional information is require, waiting for response Triage: Need PO Confirmation Requirements should be clarified/approved/confirmed with Product Manager. Not ready for fix/delivery labels Jun 14, 2021
@github-jira-sync-bot github-jira-sync-bot added the Priority: P3 May be fixed according to the position in the backlog. label Aug 20, 2021
@engcom-Hotel engcom-Hotel moved this to In Progress in Feature Requests Backlog Aug 19, 2024
@engcom-Delta
Copy link
Contributor

Hi

Thanks for your reporting and collaboration.
We have verified the issue in 2.4 develop instance, It is an improvement so we will mark ticket as feature request.. Kindly refer the screenshots.

Steps to reproduce :

  1. Enable the Fixed Product Tax module;
  2. Create the FPT and associate it to the default attribute set;
  3. Create a product with the FPT configured:
  4. Go to the frontend, add the product to the cart and assert that the tax is being charged (make sure to select the right country);

Image

  1. Go back to the admin and create a 100% discount coupon code:
  2. Enable the Free shipping delivery method:
  3. Go back to the frontend, to the cart, and apply your coupon;
  4. Verify that the order still has $0.99 left to be paid;

Image

  1. Go to the checkout billing page to make sure the rule is still applicable
  2. Observe , WEEE/FPT is charged regardless of cart rules;
    No way to control if WEEE/FPT should be charged regardless of the cart rule

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Rule Component: Tax feature request Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reported on 2.4.1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: In Progress
Development

No branches or pull requests

7 participants