Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Inconsistent labels for attributes in marketing rules #31232

Closed
4 tasks
m2-assistant bot opened this issue Dec 9, 2020 · 10 comments · Fixed by #31231
Closed
4 tasks

[Issue] Inconsistent labels for attributes in marketing rules #31232

m2-assistant bot opened this issue Dec 9, 2020 · 10 comments · Fixed by #31231
Assignees
Labels
Area: Admin UI Component: SalesRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. stale issue

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 9, 2020

This issue is automatically created based on existing pull request: #31231: Inconsistent labels for attributes in marketing rules


Description (*)

In task MAGETWO-94407, functionality was added for correct operation of marketing rules with configurable products. But additional labels for attributes are inconsistent. Some of them do not contain spaces, and some have a different style of writing words, some uppercase, and some uppercase letters.

Related Pull Requests

db41fab#diff-f4e77b2225e395e85ad967f315970b77f1557e94c2033038091750b2d4e11382

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Create Cart Price Rule or Catalog Price Rule rule
  2. Add Product attribute combination section
  3. Сheck the category and attribute options

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: SalesRule Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Dec 9, 2020
@krishprakash krishprakash self-assigned this Dec 25, 2020
@m2-assistant
Copy link
Author

m2-assistant bot commented Dec 25, 2020

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @krishprakash. Thank you for your request. I'm working on Magento instance for you.

@krishprakash krishprakash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Dec 25, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-40238 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@stale
Copy link

stale bot commented Apr 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot], @DmitryFurs.

Thank you for your report and collaboration!

The related internal Jira ticket MC-40238 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.

@ihor-sviziev ihor-sviziev reopened this Feb 7, 2022
@m2-community-project m2-community-project bot removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Progress: done labels Feb 7, 2022
@engcom-Bravo
Copy link
Contributor

Hi @DmitryFurs,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the attached video.

Manual testing scenarios

  • Create Cart Price Rule or Catalog Price Rule rule
  • Add Product attribute combination section
  • Сheck the category and attribute options
Screencast.from.27-02-24.11.57.43.AM.IST.webm

Some of them do not contain spaces, and some have a different style of writing words, some uppercase, and some uppercase letters.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Admin UI Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Fixed in 2.4.x The issue has been fixed in 2.4-develop branch labels Feb 27, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11427 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Feb 27, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Component: SalesRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. stale issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants