Minicart height not calculated correctly under certain circumstances

[gwharton]

Preconditions (*)

1. 2.4.0

Steps to reproduce (*)

1. Create 3 test products, all with 0 stock, all with backorders enabled with notify
2. Go to frontend and add 5 of each to your basket

Expected result (*)

1. Minicart should be sized appropriately

Actual result (*)

1. There is a large margin at the bottom of the minicart. It grows the more items there are in the cart.

Investigation

The problem is happening because in the sidebar.js function calculateHeight, as the height of the minicart area is 0 (height hasnt been caluculated yet) the scroll bar is enabled. This reduces the width of the minicart by a small amount. However it is just enough to cause the backorder messages to go onto 3 lines. This means that the height that gets calculated is too large. When the minicart is ready to be displayed, the scroll bar disappears and the minicart drawable area becomes slightly wider and the backorder messages only take up 2 lines. The minicart height is set to the correct height for the slightly narrower minicart draw area including scrollbar, thus there ends up being a big whitespace area at the base.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @gwharton. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[ajijshekh123]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-29859-2-4-develop.instances.magento-community.engineering/admin_b03b
Login: 27539f6b Password: 84258787d4d1
Instance will be terminated in up to 3 hours.

[ajijshekh123]

Hi @gwharton,
Verified this issue in the latest Magento 2.4 Instance with the above steps to be reproduced, actual result and expected result.
PFA:

Thanks.

[magento-engcom-team]

@ajijshekh123 Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

• Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

[magento-engcom-team]

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-37290 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[gwharton]

The effect is much more pronounced if the product name is short enough so that the backorder message goes onto two lines without scrollbar and onto three lines with the scrollbar.

[magento-engcom-team]

Hi @rodrigowebjump, here is your Magento instance.
Admin access: https://i-29859-2-4-develop.instances.magento-community.engineering/admin_a008
Login: 2558e2ce Password: 10e6a0dc9491
Instance will be terminated in up to 3 hours.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[gwharton]

Not stale

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[gwharton]

Still not stale.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 28 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[Melnychuk-Alexandr]

@magento I am working on this

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://047ae8f23aa0e6240f981cb098c8b713.instances-prod.magento-community.engineering
Admin access: https://047ae8f23aa0e6240f981cb098c8b713.instances-prod.magento-community.engineering/admin_a056
Login: 309d8397
Password: 9d09f9e69365

[engcom-Bravo]

Hi @gwharton,

Thanks for your reporting and collaboration,

We have verified the issue in Latest 2.4-develop instance and the issue is no more reproducible.Kindly refer the screenshots.

Minicart is sized appropriately.

Hence we are closing this issue.

Thanks.