Skip to content

Magento/Multishipping: Setting wrong back url on creation New Customer Shipping Address Page #24701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Totem4ik opened this issue Sep 23, 2019 · 14 comments
Assignees
Labels
Component: Checkout Component: Multishipping Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Totem4ik
Copy link

Preconditions (*)

  1. Magento 2.3.2
  2. Sample data installed

Steps to reproduce (*)

  1. Create new customer (customer should not have addresses).
  2. Add some product to cart.
  3. Open cart.
  4. Click "Check Out with Multiple Addresses".
  5. On "Create shipping address" page click "Back button".

Expected result (*)

  1. Url in Back button : https://example.com/checkout/cart/.
  2. Back on checkout cart.

Actual result (*)

  1. Url in Back button : https://example.com/multishipping/cart/.
  2. Get 404 page.
@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2019

Hi @Totem4ik. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Totem4ik do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 23, 2019
@engcom-Bravo engcom-Bravo self-assigned this Sep 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123 ajijshekh123 self-assigned this Sep 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 24, 2019

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123 ajijshekh123 added Component: Checkout Component: Multishipping Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Sep 24, 2019
@ajijshekh123
Copy link

Give me @magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-24701-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ajijshekh123
Copy link

@Totem4ik - I have reproduced this issue as per your steps and scenario. Back functionality is working fine in the latest Magento 2.3 instance.
Please review attach the video:

Backbutton Issue

@ajijshekh123 ajijshekh123 added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Sep 24, 2019
@Totem4ik
Copy link
Author

@ajijshekh123 Hi! Thank you! One more detail what i missed. "Back Button" hide on this theme, but if you make a visible this block, you'll see that problem.
I attach two images to show you what i mean
magento_bug
magento_bug_3

@engcom-Bravo engcom-Bravo added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch labels Sep 24, 2019
@ghost ghost unassigned engcom-Bravo Sep 24, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 24, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-20370 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ajijshekh123 ajijshekh123 removed their assignment Sep 24, 2019
@MaxSouza
Copy link
Contributor

MaxSouza commented Oct 1, 2019

@Totem4ik for default the button is hidden, so it does not an error. We can't reproduced your issue.

@Totem4ik
Copy link
Author

Totem4ik commented Oct 2, 2019

@MaxSouza you have this functionality in core of magento2 on backend. So, behavior of this functional is wrong. This doesn't a theme problem, this problem in core, so when we using another theme this bug doesn't hidden. How to reproduce this issue you can find above in topic and comment with screenshot.
Could you remove behavior of this button from controller or fix it ?

@MaxSouza MaxSouza self-assigned this Oct 2, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 2, 2019

Hi @MaxSouza. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@MaxSouza
Copy link
Contributor

MaxSouza commented Oct 2, 2019

@Totem4ik Ah ok, I'll fix the url.

@magento-engcom-team
Copy link
Contributor

Hi @Totem4ik. Thank you for your report.
The issue has been fixed in #24827 by @MaxSouza in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.4 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Component: Multishipping Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants