Skip to content

The display watermark size is incorrect compared to the original watermark images on list product,product page on magento2.3.2 #23515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jordantran93 opened this issue Jul 1, 2019 · 11 comments
Assignees
Labels
Component: Theme Event: cd19latam Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@jordantran93
Copy link

Preconditions (*)

1.Magento 2.3.2 community edition
2. Fresh installation, no third party modules

Steps to reproduce (*)

  1. Go to Content -> Design->Configuration -> Edit Theme Luma
    https://prnt.sc/o8u05g
    2.set watermark image opacity to 99, image size to 255x68, image position to Bottom/Left, and saved configuration. https://prnt.sc/o8u1py
    3.set small watermark image opacity to 99, image size to 147x38, image position to Bottom/Left, and saved configuration. https://prnt.sc/o8u0fu

Expected result (*)

  1. watermark images size same image size uploaded is 147x38 on list page, 255x68 size on product page. https://prnt.sc/o8u3co https://prnt.sc/o8u3hk

Actual result (*)

  1. On product page and list product page show watermark smaller than origin watermark uploaded https://prnt.sc/o8u36k https://prnt.sc/o8u3lx
  2. with images have size different will show watermark have size different and position also different https://prnt.sc/o8u2wa
@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2019

Hi @jordantran93. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@jordantran93 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 1, 2019
@engcom-Bravo engcom-Bravo self-assigned this Jul 1, 2019
@engcom-Bravo engcom-Bravo added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Theme Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jul 1, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 1, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-17914 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@wbeltranc
Copy link
Contributor

#cd19latam

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2019

Hi @wbeltranc. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@rschulerdh
Copy link

@magento I am working on it

@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2019

Hi @rschulerdh! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and self-assign the issue.

@rschulerdh rschulerdh assigned rschulerdh and unassigned wbeltranc Sep 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2019

Hi @rschulerdh. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@ghost ghost unassigned rschulerdh Oct 9, 2019
@mattheo-geoffray
Copy link

@magento I am working on it

@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2019

Hi @mattheo-geoffray! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and self-assign the issue.

@Dnd-Dboy Dnd-Dboy self-assigned this Oct 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2019

Hi @Dnd-Dboy. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@ghost ghost assigned Krielkip Nov 8, 2019
@VladimirZaets VladimirZaets added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 14, 2019
@VladimirZaets
Copy link
Contributor

Hi @jordantran93. Thank you for your report.
The issue has been fixed in #25528 by @Krielkip in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Event: cd19latam Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

10 participants