Unnecessary recalculation of product list pricing causes huge slowdowns

[paales]

Preconditions

1. 2.2.2
2. PHP 7.0, MySQL 5.6

Steps to reproduce

1. Create a catalog where prices are including tax + prices are shown including tax.
2. Go to a category page and show 100 products per page.

Expected result

1. System does price calculation very efficiently

Actual result

1. It recalculates the tax while it shouldn't be doing that.

If we can disable the recalculation of tax we get the following result:

Please note that this is with xdebug enabled, so overal performance is bad over here, but the percentual difference is present with xdebug disabled.

The problem seems to lie in the following method:

magento2/app/code/Magento/Tax/Model/Config.php

Lines 847 to 849 in 9c14af7

	case self::DISPLAY_TYPE_INCLUDING_TAX:
	$res = true;
	break;

The highlighted line should be false. If we fix that line the calculation time for the price template goes from 4.3 seconds to 1.6 seconds. This means a 2.7 seconds performance improvement.

In the last chart you can still see room for improvement as the final_price.phtml tempalte still takes 31% of total page load time, while I would expect this to be a lot less. So investigating further still.

[magento-engcom-team]

Hi @paales. Thank you for your report.
The issue has been fixed in #15089 by @JeroenVanLeusden in 2.2-develop branch
Related commit(s):

• c5536d3721989b97ec0bc02ec174d898067d4dcb

The fix will be available with the upcoming 2.2.5 release.

[ishakhsuvarov]

Hi @paales. Thank you for your report.
The issue has been fixed in #15445 by @JeroenVanLeusden in 2.1-develop branch
Related commit(s):

• 3d05e6b5361d28877ac97e7dfd264b8b5ccf6482

The fix will be available with the upcoming 2.1.15 release.

[magento-engcom-team]

Hi @paales. Thank you for your report.
The issue has been fixed in #15200 by @JeroenVanLeusden in 2.3-develop branch
Related commit(s):

• 08cf8b878a9919b95b44ef69b04830532d487c24

The fix will be available with the upcoming 2.3.0 release.