Skip to content

Output of setup:static-content:deploy contains red color, should be a friendlier color #12404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hostep opened this issue Nov 22, 2017 · 6 comments
Labels
feature request Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue

Comments

@hostep
Copy link
Contributor

hostep commented Nov 22, 2017

Preconditions

  1. macOS 10.12.6
  2. iTerm2 3.1.5 with Solarized Dark theme
  3. Magento 2.2.1
  4. PHP 7.0.25

Steps to reproduce

  1. Setup a fresh Magento 2.2.1 installation
  2. Execute: bin/magento setup:static-content:deploy -f --theme Magento/blank en_US

Expected result

  1. Output with friendly colors that don't give the impression that something went wrong

Actual result

  1. Seeing a bunch of red colors on the screen, which makes you think something went wrong.
    screen shot 2017-11-22 at 15 57 39

Discussion

I actually didn't notice this when working locally, but when deploying to a server. We see in the output of our deployment scripts a bunch of red colors, which almost always means something is going terribly wrong, but when looking closer at the output, it was just telling us what strategy is being used and how long it took.
I would suggest changing this color to something more friendly, like blue or green for example.
I don't know if there are some kind of Magento standards for the colors being used in the output of cli commands?

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Nov 22, 2017
@magento-engcom-team
Copy link
Contributor

@hostep, thank you for your report.
This seems to be correct Magento behavior. Please refer to the Community Forums or the Magento Stack Exchange site for advice or general discussion about this.
Otherwise you may submit Pull Request with the suggested changes.

@hostep
Copy link
Contributor Author

hostep commented Nov 23, 2017

Ok ...

I'm willing to submit a PR to fix this, but I need some feedback regarding if there is some kind of standard or policy for what colors we can use in what cases on the cli.

@magento-engcom-team: if you can provide some suggestions, that would be appreciated :)

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Nov 25, 2017

It was also not clear for me why it red, I was thinking there is an error somewhere. I think would be better replace with green color

@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for the report. We are moving your feature request to the special project. You can track this issue here: magento/community-features#15

@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your report.
The issue has been fixed in #13709 by @hostep in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.4 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your report.
The issue has been fixed in #13975 by @hostep in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue
Projects
None yet
Development

No branches or pull requests

3 participants