Skip to content

Magento 2.1.8 : Cart Rules + New Customer (Please enter a valid date) Locale AU #10754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gilbertsohal opened this issue Sep 3, 2017 · 19 comments
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@gilbertsohal
Copy link

gilbertsohal commented Sep 3, 2017

Preconditions

  1. Magento CE 2.1.8
  2. PHP version: 7.0
  3. Locale AU

Steps to reproduce

Set Locale AU

  1. Stores > Configuration >General > General > Locale Options
    Set Default Country to Australia and Locale to AU
    Step 1 Screenshot
    https://prnt.sc/ggek4e

  2. Admin > Account Settings > My Account > Account Information
    Set Interface Locale to English Australia
    Step 2 Screenshot
    https://prnt.sc/ggelkj

  3. Stores > Configuration >Catalog > Catalog >Date & Time Custom Options
    Use JavaScript Calendar to Yes and Date Fields Order to dd/mm/yyyy
    Step 3 Screenshot
    https://prnt.sc/ggemrx

  4. Date format working fine on frontend (dd/mm/yyyy)
    Step 4 Screensho
    https://prnt.sc/ggen57

DATE FORMAT NOT WORKING ON BACKEND

Cart Price Rules

  1. Navigate to Marketing > Cart Price Rules > Add New Rule
  2. Select start date 20/09/2017 with date picker
  3. Select end date 28/09/2017 with date picker

Screenshot 1
If the date format is dd/mm/yyyy (29/09/2017)
https://prnt.sc/ggejfg

Screenshot 2
If the date format is mm/dd/yyyy (11/09/2017)
https://prnt.sc/ggep2u

New Customer

  1. Add New Customer on Front-end date format is
    (dd/mm/yyyy) 20/08/1981
    Step1 Screenshot
    https://prnt.sc/ggeqor

  2. Go to Customers > All Customers > Edit
    Step2 Screenshot
    https://prnt.sc/ggero2

  3. Go to Customers > All Customers > Edit > Customer Information > Account Information
    Date of birth field showing Account Created date
    Step3 Screenshot
    https://prnt.sc/ggesad

Account Created date
Step4 Screenshot
https://prnt.sc/gget53

If you tried to change
Step5 Screenshot
https://prnt.sc/ggetiw

Expected result

Cart Price Rules

  1. Select start date 20/09/2017 with date picker
  2. Select end date 28/09/2017 with date picker

New Customer

  1. Date of birth in list should be dd/mm/yyyy format
    Step1 Screenshot
    https://prnt.sc/ggero2

  2. Date of birth should be original date of birth which capture from fronted (20/08/1981)
    Step2 Screenshot
    https://prnt.sc/gget53

Actual result

Cart Price Rules

  1. Navigate to Marketing > Cart Price Rules > Add New Rule
  2. Select start date 20/09/2017 with date picker
  3. Select end date 28/09/2017 with date picker

Screenshot 1
If the date format is dd/mm/yyyy (29/09/2017)
https://prnt.sc/ggejfg

Screenshot 2
If the date format is mm/dd/yyyy (11/09/2017)
https://prnt.sc/ggep2u

New Customer

  1. Add New Customer on Front-end date format is
    (dd/mm/yyyy) 20/08/1981
    Step1 Screenshot
    https://prnt.sc/ggeqor

  2. Go to Customers > All Customers > Edit
    Step2 Screenshot
    https://prnt.sc/ggero2

  3. Go to Customers > All Customers > Edit > Customer Information > Account Information
    Date of birth field showing Account Created date
    Step3 Screenshot
    https://prnt.sc/ggesad

Account Created date
Step4 Screenshot
https://prnt.sc/gget53

If you tried to change
Step5 Screenshot
https://prnt.sc/ggetiw

@gilbertsohal
Copy link
Author

@TomashKhamlai

Could you please guide me what to do?

@magento-engcom-team magento-engcom-team added bug report G1 Passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@deckside
Copy link

I have the same problem this started after upgrading from CE2.17 to CE2.18

@okorshenko okorshenko added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 14, 2017
@orlangur
Copy link
Contributor

Seems to be a duplicate of #10580 (not closing as they both are G3 Passed).

@magento-engcom-team
Copy link
Contributor

@gilbertsohal, thank you for your report.
The issue is already fixed in develop branch
But we will consider to backport the fix to patch releases

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 22, 2017
@gilbertsohal
Copy link
Author

@magento-engcom-team ohh great, Could you please confirm when you have plan to release patch.

@patrick-bigbridge
Copy link

@magento-engcom-team Please provide commit id of fix so that we can apply the change.

@adie1980
Copy link

@magento-engcom-team are you able to provide details of the fix? I have the same problem with Magento 2.1.9 and since upgrading, it won't let me save or amend any cart price rules, nor other extensions where a date has to be entered. "Please Enter A Valid Date". (although I am UK Locale)

@damjess
Copy link

damjess commented Sep 27, 2017

@magento-engcom-team Same problem in 2.1.9, similar problem in add/edit product for "Set as New," researching if it's connected...

Edit: Solution to add/edit "Set Product as New From" error found here -#10485

@gilbertsohal
Copy link
Author

gilbertsohal commented Sep 27, 2017

@magento-engcom-team Have you fixed this issue in ver 2.2.0?

@nelero
Copy link

nelero commented Sep 27, 2017

Is this bug is fixed ? real problem with start/end date for catalog rules, set as new from/to dates, dob customer when locale is not en_US. (ie fr_FR)
really painfull for production websites....

@gilbertsohal
Copy link
Author

@okorshenko Have you fixed this issue?

@gilbertsohal
Copy link
Author

@okobchenko

Have you fixed this issue? I tried with fresh installation (2.1.9 AU) this issue still present in 2.1.9. Please help

@adie1980
Copy link

adie1980 commented Nov 1, 2017

As a temporary fix for my store, I changed in admin “account settings” (found in top-right dropdown - where you set your admin username and password) the interface locale to English (United States).. this only changes the admin interface local (you can still have the front end store set as your local country interface (ie. Locale AU, or in my case UK locale)..

After I did this - now the date inputs work fine when setting cart rules / new product dates / sale price dates etc.. it’s not ideal but it worked for me..

@gilbertsohal
Copy link
Author

@magento-engcom-team @orlangur

Have you fixed this issue? I still facing same issue in 2.1.10 Please help?

@sergiomendonca
Copy link

Magento 2.2 updated in December still have this bug. And have another many bugs associated by dates, like filters, entire marketing modulo, from to in catalog module...

@magento-engcom-team
Copy link
Contributor

Hi @gilbertsohal. Thank you for your report.
The issue has been fixed in #11306 by @raumatbel in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@patrick-bigbridge
Copy link

I tried this commit. It doesn't work for me for the case described in this issue.

@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost
Copy link

ghost commented Nov 19, 2018

Hi @gilbertsohal The issue was re-tested and we can confirm that it was fixed on the 2.3 release branch. We closing this issue as fixed due to upcoming 2.3 release that will be available soon.

@ghost ghost closed this as completed Nov 19, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests