Skip to content

Merging / Bundling JS Files Production Mode breaks Regular Expressions #10562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulftietze opened this issue Aug 17, 2017 · 4 comments
Closed
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@ulftietze
Copy link
Member

ulftietze commented Aug 17, 2017

Preconditions

  1. Magento 2.1.X (explict tested with 2.1.2, also shouldn't work with all other versions)
  2. PHP 7.0.X
  3. Production Mode
  4. Enabled JS Bundling (Configuration > Advanced > Developer > JavaScript Settings)

Steps to reproduce

  1. Create a custom JS File which should do some Regular Expressions (e.g. Input Fields in Checkout)
  2. Inside if Validation e.g. do a /^([a-zA-ZßäöüÄÖÜ\s.]{3,})+$/
  3. Run php bin/magento setup:static-content:deploy

Expected result

  1. Regex should pass the following string: "Übergrößenträger"

Actual result

  1. Can't validate this string, because REGEX Validation is modified to:
    /^([a-zA-Z\u00c3\u009f\u00c3\u00a4\u00c3\u00b6\u00c3\u00bc\u00c3\u0084\u00c3\u0096\u00c3\u009c\s.]{3,})+$/
  2. This is after the json_encode of this string. Before Magento do this, here is the string that Magento creates: /^([a-zA-Z�äöü���\s.]{3,})+$/
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-71647

@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report develop labels Sep 1, 2017
@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report develop Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team
Copy link
Contributor

@ulftietze, thank you for your report.
The issue is already fixed in develop branch
But we will consider to backport the fix to patch releases

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 20, 2017
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 1, 2017
@okorshenko okorshenko removed the 2.3.x label Dec 14, 2017
@ghost ghost self-assigned this Nov 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost
Copy link

ghost commented Nov 19, 2018

Hi @ulftietze The issue was re-tested and we can confirm that it was fixed on the 2.3 release branch. We closing this issue as fixed due to upcoming 2.3 release that will be available soon.

@ghost ghost closed this as completed Nov 19, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

5 participants