MAGETWO-49633: [GITHUB] Forked PHP threads in Magento must use strictly same PHP executable used for running original entry point #3482

 - implemented wrapper for Symfony class

Author: Eddie Lau

app/code/Magento/Cron/Observer/ProcessCronQueueObserver.php

@@ -114,7 +114,7 @@ class ProcessCronQueueObserver implements ObserverInterface
      * @param \Magento\Framework\App\Console\Request $request
      * @param \Magento\Framework\ShellInterface $shell
      * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $timezone
-     * @param \Symfony\Component\Process\PhpExecutableFinder $phpExecutableFinder
+     * @param \Magento\Framework\Process\PhpExecutableFinder $phpExecutableFinder
      */
     public function __construct(
         \Magento\Framework\ObjectManagerInterface $objectManager,
@@ -125,7 +125,7 @@ public function __construct(
         \Magento\Framework\App\Console\Request $request,
         \Magento\Framework\ShellInterface $shell,
         \Magento\Framework\Stdlib\DateTime\TimezoneInterface $timezone,
-        \Symfony\Component\Process\PhpExecutableFinder $phpExecutableFinder
+        \Magento\Framework\Process\PhpExecutableFinder $phpExecutableFinder
     ) {
         $this->_objectManager = $objectManager;
         $this->_scheduleFactory = $scheduleFactory;

app/code/Magento/Cron/Test/Unit/Observer/ProcessCronQueueObserverTest.php

@@ -110,7 +110,7 @@ public function setUp()
 
         $this->timezone = $this->getMock('Magento\Framework\Stdlib\DateTime\TimezoneInterface');
         $this->timezone->expects($this->any())->method('scopeTimeStamp')->will($this->returnValue(time()));
-        $phpExecutableFinder = $this->getMock('Symfony\Component\Process\PhpExecutableFinder', [], [], '', false);
+        $phpExecutableFinder = $this->getMock('Magento\Framework\Process\PhpExecutableFinder', [], [], '', false);
         $phpExecutableFinder->expects($this->any())->method('find')->willReturn('php');
         $this->_observer = new ProcessCronQueueObserver(
             $this->_objectManager,

app/code/Magento/Cron/composer.json

@@ -4,8 +4,7 @@
     "require": {
         "php": "~5.5.0|~5.6.0|~7.0.0",
         "magento/module-store": "100.0.*",
-        "magento/framework": "100.0.*",
-        "symfony/process": "~2.1"
+        "magento/framework": "100.0.*"
     },
     "suggest": {
         "magento/module-config": "100.0.*"

lib/internal/Magento/Framework/Process/PhpExecutableFinder.php

@@ -0,0 +1,10 @@
+<?php
+/**
+ * Copyright © 2015 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Framework\Process;
+
+class PhpExecutableFinder extends \Symfony\Component\Process\PhpExecutableFinder
+{
+}

lib/internal/Magento/Framework/composer.json

@@ -19,7 +19,8 @@
         "ext-gd": "*",
         "ext-openssl": "*",
         "lib-libxml": "*",
-        "ext-xsl": "*"
+        "ext-xsl": "*",
+        "symfony/process": "~2.1"
     },
     "suggest": {
         "ext-imagick": "Use Image Magick >=3.0.0 as an optional alternative image processing library"