MC-34427: Cleanup travis configuration

Author: xmav

.github/CONTRIBUTING.md

@@ -23,7 +23,7 @@ For more detailed information on contribution please read our [beginners guide](
 * Unit/integration test coverage
 * Proposed [documentation](https://devdocs.magento.com) updates. Documentation contributions can be submitted via the [devdocs GitHub](https://github.com/magento/devdocs).
 4. For larger features or changes, please [open an issue](https://github.com/magento/magento2/issues) to discuss the proposed changes prior to development. This may prevent duplicate or unnecessary effort and allow other contributors to provide input.
-5. All automated tests must pass (all builds on [Travis CI](https://travis-ci.org/magento/magento2) must be green).
+5. All automated tests must pass.
 
 ## Contribution process
 

.htaccess

@@ -238,15 +238,6 @@
             Require all denied
         </IfVersion>
     </Files>
-    <Files .travis.yml>
-        <IfVersion < 2.4>
-            order allow,deny
-            deny from all
-        </IfVersion>
-        <IfVersion >= 2.4>
-            Require all denied
-        </IfVersion>
-    </Files>
     <Files CHANGELOG.md>
         <IfVersion < 2.4>
             order allow,deny

.htaccess.sample

@@ -238,15 +238,6 @@
             Require all denied
         </IfVersion>
     </Files>
-    <Files .travis.yml>
-        <IfVersion < 2.4>
-            order allow,deny
-            deny from all
-        </IfVersion>
-        <IfVersion >= 2.4>
-            Require all denied
-        </IfVersion>
-    </Files>
     <Files CHANGELOG.md>
         <IfVersion < 2.4>
             order allow,deny

dev/tests/integration/etc/install-config-mysql.travis.php.dist

@@ -32,7 +32,7 @@ protected function setUp(): void
      */
     public function testAppReinitializationNoMemoryLeak()
     {
-        $this->markTestSkipped('Test fails at Travis. Skipped until MAGETWO-47111');
+        $this->markTestSkipped('Skipped until MAGETWO-47111');
 
         $this->_deallocateUnusedMemory();
         $actualMemoryUsage = $this->_helper->getRealMemoryUsage();

dev/tests/integration/testsuite/Magento/Framework/Composer/_files/testFromCreateProject/composer.lock

@@ -5,6 +5,9 @@
  */
 namespace Magento\Phpserver;
 
+use Symfony\Component\Process\PhpExecutableFinder;
+use Symfony\Component\Process\Process;
+
 /**
  * @magentoAppIsolation enabled
  *
@@ -19,33 +22,15 @@ class PhpserverTest extends \PHPUnit\Framework\TestCase
 {
     const BASE_URL = '127.0.0.1:8082';
 
-    private static $serverPid;
-
     /**
-     * @var \Laminas\Http\Client
+     * @var Process
      */
-    private $httpClient;
+    private $serverProcess;
 
     /**
-     * Instantiate phpserver in the pub folder
+     * @var \Laminas\Http\Client
      */
-    public static function setUpBeforeClass(): void
-    {
-        if (!(defined('TRAVIS') && TRAVIS === true)) {
-            self::markTestSkipped('Travis environment test');
-        }
-        $return = [];
-
-        $baseDir = __DIR__ . '/../../../../../../';
-        $command = sprintf(
-            'cd %s && php -S %s -t ./pub/ ./phpserver/router.php >/dev/null 2>&1 & echo $!',
-            $baseDir,
-            static::BASE_URL
-        );
-        // phpcs:ignore
-        exec($command, $return);
-        static::$serverPid = (int) $return[0];
-    }
+    private $httpClient;
 
     private function getUrl($url)
     {
@@ -55,11 +40,33 @@ private function getUrl($url)
     protected function setUp(): void
     {
         $this->httpClient = new \Laminas\Http\Client(null, ['timeout' => 10]);
+
+        /** @var Process $process */
+        $phpBinaryFinder = new PhpExecutableFinder();
+        $phpBinaryPath = $phpBinaryFinder->find();
+        $command = sprintf(
+            "%s -S %s -t ./pub ./phpserver/router.php",
+            $phpBinaryPath,
+            self::BASE_URL
+        );
+        $this->serverProcess = Process::fromShellCommandline(
+            $command,
+            realpath(__DIR__ . '/../../../../../../')
+        );
+        $this->serverProcess->start();
+        $this->serverProcess->waitUntil(function ($type, $output) {
+            return strpos($output, "Development Server") !== false;
+        });
+    }
+
+    protected function tearDown(): void
+    {
+        $this->serverProcess->stop();
     }
 
     public function testServerHasPid()
     {
-        $this->assertTrue(static::$serverPid > 0);
+        $this->assertTrue($this->serverProcess->getPid() > 0);
     }
 
     public function testServerResponds()
@@ -86,9 +93,4 @@ public function testStaticImageFile()
         $this->assertFalse($response->isClientError());
         $this->assertStringStartsWith('image/gif', $response->getHeaders()->get('Content-Type')->getMediaType());
     }
-
-    public static function tearDownAfterClass(): void
-    {
-        posix_kill(static::$serverPid, SIGKILL);
-    }
 }