Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop preference xml inspections #566

Closed
bohdan-harniuk opened this issue Apr 21, 2021 · 2 comments · Fixed by #578
Closed

Develop preference xml inspections #566

bohdan-harniuk opened this issue Apr 21, 2021 · 2 comments · Fixed by #578
Assignees

Comments

@bohdan-harniuk
Copy link
Collaborator

We should have preference XML attributes inspections:

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <preference for="Foo\Bar\Api\Data\FooAInterface" type="Foo\Bar\Model\Data\FooB"/>
</config>

For example, above we have two declared classes:

  1. Foo\Bar\Api\Data\FooAInterface
  2. Foo\Bar\Model\Data\FooB

What if the Foo\Bar\Api\Data\FooAInterface is a typo?
What if the Foo\Bar\Model\Data\FooBe is a typo too?

We need to cover this inspection to show if any of these classes don't exist.

@m2-assistant
Copy link

m2-assistant bot commented Apr 21, 2021

Hi @bohdan-harniuk. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@Iamwade
Copy link
Collaborator

Iamwade commented Apr 21, 2021

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants