Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor folder not found when using mage-os fork #1944

Closed
ProxiBlue opened this issue Mar 1, 2024 · 5 comments
Closed

Vendor folder not found when using mage-os fork #1944

ProxiBlue opened this issue Mar 1, 2024 · 5 comments
Assignees
Labels

Comments

@ProxiBlue
Copy link

ProxiBlue commented Mar 1, 2024

Using community fork mage-os does not work with the plugin, and results in error : 'Vendor dir is corrupt or missing in the current Magento 2 installation path', when setting the mage-os path in plugin configuration.

Steps to reproduce the behavior:

  1. Install mage-os fork. Ref https://mage-os.org/
  2. Setup PHPStorm project to the above install
  3. Install / activate this module
  4. setup this module and point folder to root folder
  5. See this error

Expected behavior (*)

Acceptance of the mage-os vendor folder

image

Having had a quick look, I can see the issue is related to fact that mage-os has moved vendor folder away from /vendor/magento to /vendor/mage-os (a logical move)
This module uses hardcoded paths to /vendor/magento to check for setups

image

Please complete the following information: (*)

  • OS: Ubuntu
  • PhpStorm/Intellij version: 2023.3.4
  • Plugin Version: 5.1.1

My suggestion si that the base magento folder should be a configurable value, and paths should be built using that, and not hadcoded to /vendor/magento

a workaround is to add a symlink from old magento folder to mage-os, via composer, so it is generated if vendor is wiped.

 "scripts": {
       "post-install-cmd": [
            "mkdir -p ./vendor/magento && ln -s ./vendor/mage-os/framework ./vendor/magento/"
        ],
}
@ProxiBlue ProxiBlue added the bug label Mar 1, 2024
Copy link

m2-assistant bot commented Mar 1, 2024

Hi @ProxiBlue. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@SilinMykola
Copy link
Contributor

@magento I am working on this

@VitaliyBoyko
Copy link
Contributor

@SilinMykola it is supposed to be fixed here #2081. Could you just check and close if so?

@SilinMykola
Copy link
Contributor

@VitaliyBoyko, I checked the issue locally, and everything is working fine. We can close the issue.

Image

@VitaliyBoyko
Copy link
Contributor

@SilinMykola thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants