Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] View Model can be created in the vendor #1204

Open
bohdan-harniuk opened this issue Sep 21, 2022 · 2 comments
Open

[Bug] View Model can be created in the vendor #1204

bohdan-harniuk opened this issue Sep 21, 2022 · 2 comments
Assignees
Labels

Comments

@bohdan-harniuk
Copy link
Collaborator

Describe the bug (*)

In the current implementation the Inject a new View Model for this block action can generate a view model for modules in the vendor directory.

To Reproduce (*)

Steps to reproduce the behaviour:

  1. Go to any 3rd party modules layout file in the vendor directory
  2. Open a context menu above the block declaration
  3. See the Inject a new View Model for this block action appeared
  4. Click on the action
  5. See that view model is generated in the vendor module

Expected behaviour (*)

Action should not appear for vendor modules.

Screenshots

Screenshot 2022-09-21 at 12 28 31

Screenshot 2022-09-21 at 12 28 55

Screenshot 2022-09-21 at 12 29 57

Screenshot 2022-09-21 at 12 29 15

Please complete the following information: (*)

  • OS: any
  • PhpStorm/Intellij version: any
  • Plugin Version: 4.4.0 (any)

Additional context

Mainline branch: 4.4.1-develop

@bohdan-harniuk bohdan-harniuk self-assigned this Sep 21, 2022
@m2-assistant
Copy link

m2-assistant bot commented Sep 21, 2022

Hi @bohdan-harniuk. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@anzin
Copy link
Contributor

anzin commented Oct 12, 2022

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants