22 * Copyright © Magento, Inc. All rights reserved.
33 * See COPYING.txt for license details.
44 */
5+
56package com .magento .idea .magento2plugin .magento .packages ;
67
7- import com .intellij .json .psi .*;
8- import org .apache .commons .lang .StringUtils ;
9- import org .jetbrains .annotations .NotNull ;
10- import org .jetbrains .annotations .Nullable ;
8+ import com .intellij .json .psi .JsonArray ;
9+ import com .intellij .json .psi .JsonObject ;
10+ import com .intellij .json .psi .JsonProperty ;
11+ import com .intellij .json .psi .JsonStringLiteral ;
12+ import com .intellij .json .psi .JsonValue ;
1113import java .util .ArrayList ;
1214import java .util .HashMap ;
1315import java .util .List ;
1416import java .util .Map ;
17+ import org .apache .commons .lang3 .StringUtils ;
18+ import org .jetbrains .annotations .NotNull ;
19+ import org .jetbrains .annotations .Nullable ;
1520
1621public class ComposerPackageModelImpl implements ComposerPackageModel {
17- private JsonObject sourceComposerJson ;
22+ private final JsonObject sourceComposerJson ;
23+ private static final int VENDOR_AND_PACKAGE_PARTS_LENGTH = 2 ;
1824
1925 public static final String NAME = "name" ;
2026 public static final String TYPE = "type" ;
@@ -23,7 +29,7 @@ public class ComposerPackageModelImpl implements ComposerPackageModel {
2329 public static final String PSR4 = "psr4" ;
2430 public static final String FILES = "file" ;
2531
26- public ComposerPackageModelImpl (@ NotNull JsonObject sourceComposerJson ) {
32+ public ComposerPackageModelImpl (@ NotNull final JsonObject sourceComposerJson ) {
2733 this .sourceComposerJson = sourceComposerJson ;
2834 }
2935
@@ -42,10 +48,10 @@ public String getType() {
4248 @ Nullable
4349 @ Override
4450 public String getVendor () {
45- String nameProperty = getStringPropertyValue (NAME );
51+ final String nameProperty = getStringPropertyValue (NAME );
4652 if (nameProperty != null ) {
47- String [] vendorAndPackage = nameProperty .split ("/" );
48- if (vendorAndPackage .length == 2 ) {
53+ final String [] vendorAndPackage = nameProperty .split ("/" );
54+ if (vendorAndPackage .length == VENDOR_AND_PACKAGE_PARTS_LENGTH ) {
4955 return vendorAndPackage [0 ];
5056 }
5157 }
@@ -62,63 +68,69 @@ public String getVersion() {
6268 @ Nullable
6369 @ Override
6470 public String [] getAutoloadFiles () {
65- JsonObject autoloadObject = getPropertyValueOfType (AUTOLOAD , JsonObject .class );
71+ final JsonObject autoloadObject = getPropertyValueOfType (AUTOLOAD , JsonObject .class );
6672 if (autoloadObject != null ) {
67- JsonArray jsonArray = getPropertyValueOfType (FILES , JsonArray .class );
68- if (jsonArray != null ) {
69- List <String > files = new ArrayList <>();
70- for (JsonValue value : jsonArray .getValueList ()) {
71- if (value instanceof JsonStringLiteral ) {
72- files .add (StringUtils .strip (value .getText (), "\" " ));
73- }
73+ return new String [0 ];
74+ }
75+
76+ final JsonArray jsonArray = getPropertyValueOfType (FILES , JsonArray .class );
77+ if (jsonArray != null ) {
78+ final List <String > files = new ArrayList <>();
79+ for (final JsonValue value : jsonArray .getValueList ()) {
80+ if (value instanceof JsonStringLiteral ) {
81+ files .add (StringUtils .strip (value .getText (), "\" " ));
7482 }
75- return files .size () > 0 ? files .toArray (new String [files .size ()]) : null ;
7683 }
84+ return files .isEmpty () ? new String [0 ] : files .toArray (new String [0 ]);
7785 }
7886
79- return null ;
87+ return new String [ 0 ] ;
8088 }
8189
8290 @ Nullable
8391 @ Override
8492 public Map <String , String > getAutoloadPsr4 () {
85- JsonObject autoloadObject = getPropertyValueOfType (AUTOLOAD , JsonObject .class );
86- if (autoloadObject != null ) {
87- JsonObject jsonObject = getPropertyValueOfType (PSR4 , JsonObject .class );
88- if (jsonObject != null ) {
89- Map <String , String > map = new HashMap <String , String >();
90- for (JsonProperty property : jsonObject .getPropertyList ()) {
91- JsonValue value = property .getValue ();
92-
93- if (value != null && value instanceof JsonStringLiteral ) {
94- map .put (property .getName (), StringUtils .strip (value .getText (), "\" " ));
95- }
96- }
93+ final JsonObject autoloadObject = getPropertyValueOfType (AUTOLOAD , JsonObject .class );
94+ final Map <String , String > map = new HashMap <>();
95+ if (autoloadObject == null ) {
96+ return map ;
97+ }
9798
98- return map .size () > 0 ? map : null ;
99+ final JsonObject jsonObject = getPropertyValueOfType (PSR4 , JsonObject .class );
100+ if (jsonObject != null ) {
101+ for (final JsonProperty property : jsonObject .getPropertyList ()) {
102+ final JsonValue value = property .getValue ();
103+ if (value instanceof JsonStringLiteral ) {
104+ map .put (property .getName (), StringUtils .strip (value .getText (), "\" " ));
105+ }
99106 }
100107 }
101108
102- return null ;
109+ return map ;
103110 }
104111
105112 @ Nullable
106- public <T extends JsonValue > T getPropertyValueOfType (String propertyName , @ NotNull Class <T > aClass ) {
107- JsonProperty property = sourceComposerJson .findProperty (propertyName );
113+ @ Override
114+ public <T extends JsonValue > T getPropertyValueOfType (final String propertyName ,
115+ @ NotNull final Class <T > thisClass ) {
116+ final JsonProperty property = sourceComposerJson .findProperty (propertyName );
108117 if (property == null ) {
109118 return null ;
110119 }
111- JsonValue value = property .getValue ();
112- if (value != null && aClass .isInstance (value )) {
113- return aClass .cast (value );
120+ final JsonValue value = property .getValue ();
121+ if (thisClass .isInstance (value )) {
122+ return thisClass .cast (value );
114123 }
115124
116125 return null ;
117126 }
118127
119128 @ Nullable
120- private String getStringPropertyValue (String propertyName ) {
121- JsonStringLiteral stringLiteral = getPropertyValueOfType (propertyName , JsonStringLiteral .class );
129+ private String getStringPropertyValue (final String propertyName ) {
130+ final JsonStringLiteral stringLiteral = getPropertyValueOfType (
131+ propertyName ,
132+ JsonStringLiteral .class
133+ );
122134
123135 if (stringLiteral != null ) {
124136 return StringUtils .strip (stringLiteral .getText (), "\" " );
0 commit comments