Skip to content

Commit 16a153b

Browse files
konarshankar07konarshankar07
committed
Code review changes
1 parent c3f37e4 commit 16a153b

3 files changed

+24
-39
lines changed

‎resources/fileTemplates/code/Magento Plugin After Method.php.html

+8-13
Original file line numberDiff line numberDiff line change
@@ -13,29 +13,24 @@
1313
<td colspan="3"><font face="verdana" size="-1">Predefined variables will take the following values:</font></td>
1414
</tr>
1515
<tr>
16-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${TYPE_NAME}</b></font></nobr></td>
16+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PARAM_DOC}</b></font></nobr></td>
1717
<td width="10">&nbsp;</td>
18-
<td width="100%" valign="top"><font face="verdana" size="-1">A class or interface which the plugin observes.</font></td>
18+
<td width="100%" valign="top"><font face="verdana" size="-1">PHP DocBlock for plugin function</font></td>
1919
</tr>
2020
<tr>
21-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_NAME}</b></font></nobr></td>
21+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${NAME}</b></font></nobr></td>
2222
<td width="10">&nbsp;</td>
23-
<td width="100%" valign="top"><font face="verdana" size="-1">An arbitrary plugin name that identifies a plugin. Also used to merge the configurations for the plugin.</font></td>
23+
<td width="100%" valign="top"><font face="verdana" size="-1">Name of the plugin function</font></td>
2424
</tr>
2525
<tr>
26-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_TYPE}</b></font></nobr></td>
26+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PARAM_LIST}</b></font></nobr></td>
2727
<td width="10">&nbsp;</td>
28-
<td width="100%" valign="top"><font face="verdana" size="-1">The name of a plugin’s class or its virtual type. Use the following naming convention when you specify this element: \Vendor\Module\Plugin\ClassName</font></td>
28+
<td width="100%" valign="top"><font face="verdana" size="-1">List of plugin function parameters</font></td>
2929
</tr>
3030
<tr>
31-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_SORTORDER}</b></font></nobr></td>
31+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${RETURN_VARIABLES}</b></font></nobr></td>
3232
<td width="10">&nbsp;</td>
33-
<td width="100%" valign="top"><font face="verdana" size="-1">Plugins that call the same method run them using this order.</font></td>
34-
</tr>
35-
<tr>
36-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_DISABLED}</b></font></nobr></td>
37-
<td width="10">&nbsp;</td>
38-
<td width="100%" valign="top"><font face="verdana" size="-1">To disable a plugin, set this element to true. The default value is false.</font></td>
33+
<td width="100%" valign="top"><font face="verdana" size="-1">Return value for plugin function</font></td>
3934
</tr>
4035
</table>
4136
</body>

‎resources/fileTemplates/code/Magento Plugin Around Method.php.html

+8-13
Original file line numberDiff line numberDiff line change
@@ -13,29 +13,24 @@
1313
<td colspan="3"><font face="verdana" size="-1">Predefined variables will take the following values:</font></td>
1414
</tr>
1515
<tr>
16-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${TYPE_NAME}</b></font></nobr></td>
16+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PARAM_DOC}</b></font></nobr></td>
1717
<td width="10">&nbsp;</td>
18-
<td width="100%" valign="top"><font face="verdana" size="-1">A class or interface which the plugin observes.</font></td>
18+
<td width="100%" valign="top"><font face="verdana" size="-1">PHP DocBlock for plugin function</font></td>
1919
</tr>
2020
<tr>
21-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_NAME}</b></font></nobr></td>
21+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${NAME}</b></font></nobr></td>
2222
<td width="10">&nbsp;</td>
23-
<td width="100%" valign="top"><font face="verdana" size="-1">An arbitrary plugin name that identifies a plugin. Also used to merge the configurations for the plugin.</font></td>
23+
<td width="100%" valign="top"><font face="verdana" size="-1">Name of the plugin function</font></td>
2424
</tr>
2525
<tr>
26-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_TYPE}</b></font></nobr></td>
26+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PARAM_LIST}</b></font></nobr></td>
2727
<td width="10">&nbsp;</td>
28-
<td width="100%" valign="top"><font face="verdana" size="-1">The name of a plugin’s class or its virtual type. Use the following naming convention when you specify this element: \Vendor\Module\Plugin\ClassName</font></td>
28+
<td width="100%" valign="top"><font face="verdana" size="-1">List of plugin function parameters</font></td>
2929
</tr>
3030
<tr>
31-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_SORTORDER}</b></font></nobr></td>
31+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${RETURN_VARIABLES}</b></font></nobr></td>
3232
<td width="10">&nbsp;</td>
33-
<td width="100%" valign="top"><font face="verdana" size="-1">Plugins that call the same method run them using this order.</font></td>
34-
</tr>
35-
<tr>
36-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_DISABLED}</b></font></nobr></td>
37-
<td width="10">&nbsp;</td>
38-
<td width="100%" valign="top"><font face="verdana" size="-1">To disable a plugin, set this element to true. The default value is false.</font></td>
33+
<td width="100%" valign="top"><font face="verdana" size="-1">Return value for plugin function</font></td>
3934
</tr>
4035
</table>
4136
</body>

‎resources/fileTemplates/code/Magento Plugin Before Method.php.html

+8-13
Original file line numberDiff line numberDiff line change
@@ -13,29 +13,24 @@
1313
<td colspan="3"><font face="verdana" size="-1">Predefined variables will take the following values:</font></td>
1414
</tr>
1515
<tr>
16-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${TYPE_NAME}</b></font></nobr></td>
16+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PARAM_DOC}</b></font></nobr></td>
1717
<td width="10">&nbsp;</td>
18-
<td width="100%" valign="top"><font face="verdana" size="-1">A class or interface which the plugin observes.</font></td>
18+
<td width="100%" valign="top"><font face="verdana" size="-1">PHP DocBlock for plugin function</font></td>
1919
</tr>
2020
<tr>
21-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_NAME}</b></font></nobr></td>
21+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${NAME}</b></font></nobr></td>
2222
<td width="10">&nbsp;</td>
23-
<td width="100%" valign="top"><font face="verdana" size="-1">An arbitrary plugin name that identifies a plugin. Also used to merge the configurations for the plugin.</font></td>
23+
<td width="100%" valign="top"><font face="verdana" size="-1">Name of the plugin function</font></td>
2424
</tr>
2525
<tr>
26-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_TYPE}</b></font></nobr></td>
26+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PARAM_LIST}</b></font></nobr></td>
2727
<td width="10">&nbsp;</td>
28-
<td width="100%" valign="top"><font face="verdana" size="-1">The name of a plugin’s class or its virtual type. Use the following naming convention when you specify this element: \Vendor\Module\Plugin\ClassName</font></td>
28+
<td width="100%" valign="top"><font face="verdana" size="-1">List of plugin function parameters</font></td>
2929
</tr>
3030
<tr>
31-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_SORTORDER}</b></font></nobr></td>
31+
<td valign="top"><nobr><font face="verdana" size="-2"><b>${RETURN_VARIABLES}</b></font></nobr></td>
3232
<td width="10">&nbsp;</td>
33-
<td width="100%" valign="top"><font face="verdana" size="-1">Plugins that call the same method run them using this order.</font></td>
34-
</tr>
35-
<tr>
36-
<td valign="top"><nobr><font face="verdana" size="-2"><b>${PLUGIN_DISABLED}</b></font></nobr></td>
37-
<td width="10">&nbsp;</td>
38-
<td width="100%" valign="top"><font face="verdana" size="-1">To disable a plugin, set this element to true. The default value is false.</font></td>
33+
<td width="100%" valign="top"><font face="verdana" size="-1">Return value for plugin function</font></td>
3934
</tr>
4035
</table>
4136
</body>

0 commit comments

Comments
 (0)