Skip to content

Commit e537ce7

Browse files
committed
MQE-349:[PageObjects] Need to add customized function for conditional click
- fix static test issues
1 parent b8f49d0 commit e537ce7

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

src/Magento/FunctionalTestingFramework/DataGenerator/Objects/JsonElement.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ class JsonElement
5454
* @param string $key
5555
* @param string $value
5656
* @param string $type
57-
* @param array $nestedElements
5857
* @param bool $required
59-
* @param array $nestedMetadata
58+
* @param array $nestedElements
59+
* @param null|array $nestedMetadata
6060
*/
6161
public function __construct($key, $value, $type, $required, $nestedElements = [], $nestedMetadata = null)
6262
{

src/Magento/FunctionalTestingFramework/Exceptions/TestReferenceException.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,4 @@ public function __construct($message)
1919
{
2020
parent::__construct($message);
2121
}
22-
2322
}

src/Magento/FunctionalTestingFramework/Page/Objects/SectionObject.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function getElements()
5858

5959
/**
6060
* Checks to see if this section contains any element by the name of elementName
61-
* @param $elementName
61+
* @param string $elementName
6262
* @return bool
6363
*/
6464
public function hasElement($elementName)

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ class TestGenerator
3434

3535
/**
3636
* TestGenerator constructor.
37+
* @param string $exportDir
3738
*/
3839
private function __construct($exportDir)
3940
{
@@ -59,6 +60,7 @@ private function setupExportDir()
5960
* Takes a directory path and recursively deletes all files and folders.
6061
*
6162
* @param string $directory
63+
* @return void
6264
*/
6365
private function rmdirRecursive($directory)
6466
{
@@ -452,7 +454,6 @@ private function generateStepsPhp($stepsObject, $stepsData, $hookObject = false)
452454
$parameter = $this->wrapWithDoubleQuotes($customActionAttributes['parameter']);
453455
}
454456

455-
456457
if (isset($customActionAttributes['dependentSelector'])) {
457458
$dependentSelector = $this->wrapWithDoubleQuotes($customActionAttributes['dependentSelector']);
458459
}

src/Magento/FunctionalTestingFramework/Util/TestManifest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,11 @@ public function recordCest($cestName, $tests)
4949
{
5050
$fileResource = fopen($this->filePath, 'a');
5151

52-
foreach ($tests as $test)
53-
{
52+
foreach ($tests as $test) {
5453
$line = $this->relativeDirPath . DIRECTORY_SEPARATOR . $cestName . '.php:' . $test->getName();
5554
fwrite($fileResource, $line ."\n");
5655
}
5756

5857
fclose($fileResource);
5958
}
60-
}
59+
}

0 commit comments

Comments
 (0)