MQE-1861: Suite precondition failure when using <createData> with <re… (#744)

* MQE-1861: Suite precondition failure when using <createData> with <requiredEntity>

* MQE-1861: Suite precondition failure when using <createData> with <requiredEntity>
Added verification test

Author: soumyau

Diff for: dev/tests/verification/Resources/functionalSuiteHooks.txt

@@ -53,14 +53,33 @@ class functionalSuiteHooks extends \Codeception\GroupObject
                     $webDriver->_initializeSession();
                 }
                 $webDriver->amOnPage("some.url"); // stepKey: before
-                $createFields['someKey'] = "dataHere";
+                $createOneFields['someKey'] = "dataHere";
                 PersistedObjectHandler::getInstance()->createEntity(
-                    "create",
+                    "createOne",
                     "suite",
-                    "createThis",
-                     $createFields
+                    "createEntityOne",
+                    [],
+                    $createOneFields
                 );
-                $webDriver->click(PersistedObjectHandler::getInstance()->retrieveEntityField('create', 'data', 'suite')); // stepKey: clickWithData
+                PersistedObjectHandler::getInstance()->createEntity(
+                    "createTwo",
+                    "suite",
+                    "createEntityTwo",
+                    ["createEntityOne"]
+                );
+                PersistedObjectHandler::getInstance()->createEntity(
+                    "createThree",
+                    "suite",
+                    "createEntityThree",
+                    []
+                );
+                PersistedObjectHandler::getInstance()->createEntity(
+                    "createFour",
+                    "suite",
+                    "createEntityFour",
+                    ["createEntityTwo", "createEntityThree"]
+                );
+                $webDriver->click(PersistedObjectHandler::getInstance()->retrieveEntityField('createTwo', 'data', 'suite')); // stepKey: clickWithData
                 print("Entering Action Group [AC] actionGroupWithTwoArguments");
                 $webDriver->see("John", msq("uniqueData") . "John"); // stepKey: seeFirstNameAC
                 print("Exiting Action Group [AC] actionGroupWithTwoArguments");

Diff for: dev/tests/verification/Resources/functionalSuiteWithComments.txt

@@ -59,7 +59,8 @@ class functionalSuiteWithComments extends \Codeception\GroupObject
                     "create",
                     "suite",
                     "createThis",
-                     $createFields
+                    [],
+                    $createFields
                 );
                 print("<click stepKey=\"comment with element\" userInput=\"helloworld\"/>");
                 $webDriver->click(PersistedObjectHandler::getInstance()->retrieveEntityField('create', 'data', 'suite')); // stepKey: clickWithData

Diff for: dev/tests/verification/TestModule/Suite/functionalSuiteHooks.xml

@@ -13,10 +13,18 @@
         </include>
         <before>
             <amOnPage url="some.url" stepKey="before"/>
-            <createData entity="createThis" stepKey="create">
+            <createData entity="createEntityOne" stepKey="createOne">
                 <field key="someKey">dataHere</field>
             </createData>
-            <click stepKey="clickWithData" userInput="$create.data$"/>
+            <createData entity="createEntityTwo" stepKey="createTwo">
+                <requiredEntity createDataKey="createEntityOne"/>
+            </createData>
+            <createData entity="createEntityThree" stepKey="createThree"/>
+            <createData entity="createEntityFour" stepKey="createFour">
+                <requiredEntity createDataKey="createEntityTwo"/>
+                <requiredEntity createDataKey="createEntityThree"/>
+            </createData>
+            <click stepKey="clickWithData" userInput="$createTwo.data$"/>
             <actionGroup ref="actionGroupWithTwoArguments" stepKey="AC">
                 <argument name="somePerson" value="simpleData"/>
                 <argument name="anotherPerson" value="uniqueData"/>

Diff for: src/Magento/FunctionalTestingFramework/Suite/Generators/GroupClassGenerator.php

@@ -225,16 +225,16 @@ private function buildPersistenceMustacheArray($action, $entityArray)
             $action->getCustomActionAttributes()[TestGenerator::REQUIRED_ENTITY_REFERENCE];
 
         // append entries for any required entities to this entry
-        if (array_key_exists('requiredEntities', $action->getCustomActionAttributes())) {
-            $entityArray[self::REQUIRED_ENTITY_KEY] =
-                $this->buildReqEntitiesMustacheArray($action->getCustomActionAttributes());
+        $requiredEntities = $this->buildReqEntitiesMustacheArray($action->getCustomActionAttributes());
+        if (!array_key_exists(-1, $requiredEntities)) {
+            $entityArray[self::REQUIRED_ENTITY_KEY] = $requiredEntities;
         }
 
         // append entries for customFields if specified by the user.
         if (array_key_exists('customFields', $action->getCustomActionAttributes())) {
             $entityArray['customFields'] = $action->getStepKey() . 'Fields';
         }
-        
+
         return $entityArray;
     }
 

Diff for: src/Magento/FunctionalTestingFramework/Suite/views/partials/testActions.mustache

@@ -13,9 +13,9 @@ if ($webDriver->webDriver != null) {
 PersistedObjectHandler::getInstance()->createEntity(
     "{{stepKey}}",
     "suite",
-    "{{entityName}}"{{#requiredEntities}},
-    [$this->{{entityName}}{{^last}}, {{/last}}]{{/requiredEntities}}{{#customFields}},
-     ${{customFields}}{{/customFields}}
+    "{{entityName}}",
+    [{{#requiredEntities}}"{{entityName}}"{{^last}}, {{/last}}{{/requiredEntities}}]{{#customFields}},
+    ${{customFields}}{{/customFields}}
 );
 {{/createData}}
 {{#deleteData}}