Skip to content

Commit 918e7ec

Browse files
committed
MQE-2729: [PHP 8] Investigate and fix code related to changes in implode()
- Remove usage of \ReflectionParameter::getClass()
1 parent debd9ba commit 918e7ec

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/Magento/FunctionalTestingFramework/Code/Reader/ClassReader.php

+4-1
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,12 @@ public function getConstructor($className)
2424
/** @var $parameter \ReflectionParameter */
2525
foreach ($constructor->getParameters() as $parameter) {
2626
try {
27+
$name = $parameter->getType() && !$parameter->getType()->isBuiltin()
28+
? new \ReflectionClass($parameter->getType()->getName())
29+
: null;
2730
$result[] = [
2831
$parameter->getName(),
29-
$parameter->getClass() !== null ? $parameter->getClass()->getName() : null,
32+
$name !== null ? $name->getName() : null,
3033
!$parameter->isOptional(),
3134
$parameter->isOptional()
3235
? ($parameter->isDefaultValueAvailable() ? $parameter->getDefaultValue() : null)

src/Magento/FunctionalTestingFramework/System/Code/ClassReader.php

+5-2
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,12 @@ public function getParameters($className, $method)
3131
/** @var $parameter \ReflectionParameter */
3232
foreach ($method->getParameters() as $parameter) {
3333
try {
34-
$result[$parameter->getName()] = [
34+
$name = $parameter->getType() && !$parameter->getType()->isBuiltin()
35+
? new \ReflectionClass($parameter->getType()->getName())
36+
: null;
37+
$result[$parameter->getName()] = [
3538
$parameter->getName(),
36-
($parameter->getClass() !== null) ? $parameter->getClass()->getName() : null,
39+
$name !== null ? $name->getName() : null,
3740
!$parameter->isOptional(),
3841
$parameter->isOptional() ?
3942
$parameter->isDefaultValueAvailable() ? $parameter->getDefaultValue() : null :

0 commit comments

Comments
 (0)