MQE-1021: Empty Action StepKey Attribute Issues

- Added filename information for action groups actions as well

Author: aljcalandra

dev/tests/unit/Magento/FunctionalTestFramework/Test/Util/ActionGroupObjectExtractorTest.php

@@ -0,0 +1,68 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace tests\unit\Magento\FunctionalTestFramework\Test\Util;
+
+use Magento\FunctionalTestingFramework\Test\Util\ActionGroupObjectExtractor;
+use Magento\FunctionalTestingFramework\Util\MagentoTestCase;
+use tests\unit\Util\TestLoggingUtil;
+
+class ActionGroupObjectExtractorTest extends MagentoTestCase
+{
+    /** @var  ActionGroupObjectExtractor */
+    private $testActionGroupObjectExtractor;
+
+    /**
+     * Setup method
+     */
+    public function setUp()
+    {
+        $this->testActionGroupObjectExtractor = new ActionGroupObjectExtractor();
+        TestLoggingUtil::getInstance()->setMockLoggingUtil();
+    }
+
+    /**
+     * Tests basic action object extraction with an empty stepKey
+     */
+    public function testEmptyStepKey()
+    {
+        $this->expectExceptionMessage("StepKeys cannot be empty.	Action='sampleAction' in filename.xml");
+        $this->testActionGroupObjectExtractor->extractActionGroup($this->createBasicActionObjectArray(""));
+    }
+
+    /**
+     * Utility function to return mock parser output for testing extraction into ActionObjects.
+     *
+     * @param string $stepKey
+     * @param string $actionGroup
+     * @param string $filename
+     * @return array
+     */
+    private function createBasicActionObjectArray(
+        $stepKey = 'testAction1',
+        $actionGroup = "actionGroup",
+        $filename = "filename.xml"
+    ) {
+        $baseArray = [
+            'nodeName' => 'actionGroup',
+            'name' => $actionGroup,
+            'filename' => $filename,
+            $stepKey => [
+                "nodeName" => "sampleAction",
+                "stepKey" => $stepKey,
+                "someAttribute" => "someAttributeValue"
+            ]
+        ];
+        return $baseArray;
+    }
+
+    /**
+     * clean up function runs after all tests
+     */
+    public static function tearDownAfterClass()
+    {
+        TestLoggingUtil::getInstance()->clearMockLoggingUtil();
+    }
+}

src/Magento/FunctionalTestingFramework/Test/Util/ActionGroupObjectExtractor.php

@@ -62,7 +62,11 @@ public function extractActionGroup($actionGroupData)
         );
 
         // TODO filename is now available to the ActionGroupObject, integrate this into debug and error statements
-        $actions = $this->actionObjectExtractor->extractActions($actionData);
+        try {
+            $actions = $this->actionObjectExtractor->extractActions($actionData);
+        } catch (\Exception $error) {
+            throw new XmlException($error->getMessage() . " in " . $actionGroupData[self::FILENAME]);
+        }
 
         if (array_key_exists(self::ACTION_GROUP_ARGUMENTS, $actionGroupData)) {
             $arguments = $this->extractArguments($actionGroupData[self::ACTION_GROUP_ARGUMENTS]);