Merge pull request #669 from magento/MQE-2043

MQE-2043 Custom helper argument in action group is not resolved

Author: okolesnyk

dev/tests/functional/tests/MFTF/DevDocs/ActionGroup/HelperActionGroup.xml

@@ -10,11 +10,12 @@
     <actionGroup name="HelperActionGroup">
         <arguments>
             <argument name="test" type="string" />
+            <argument name="entityTest" type="entity" />
         </arguments>
         <comment userInput="Action group to demonstrate helper functionality available from action groups." stepKey="comment" />
         <helper class="\MFTF\DevDocs\Helper\CustomHelper" method="goTo" stepKey="customHelper">
-            <argument name="test">{{contentSection.parametrizedSelector(test)}}</argument>
-            <argument name="module">['{{test}}', 'Bla']</argument>
+            <argument name="test">{{contentSection.parametrizedSelector(entityTest.entityField)}}</argument>
+            <argument name="module">['{{entityTest.entityField}}', 'Bla']</argument>
             <argument name="url">{{test}}</argument>
             <argument name="bool">true</argument>
             <argument name="float">4.400000000234234</argument>

dev/tests/functional/tests/MFTF/DevDocs/Test/DevDocsTest.xml

@@ -44,6 +44,7 @@
 
         <actionGroup ref="HelperActionGroup" stepKey="actionGroupWithCustomHelper">
             <argument name="test" value="{{HelperData.entityField}}" />
+            <argument name="entityTest" value="HelperData" />
         </actionGroup>
     </test>
 </tests>

src/Magento/FunctionalTestingFramework/Test/Objects/ActionGroupObject.php

@@ -210,6 +210,9 @@ private function getResolvedActionsWithArgs($arguments, $actionReferenceKey)
         foreach ($this->parsedActions as $action) {
             $replacementStepKeys[$action->getStepKey()] = $action->getStepKey() . ucfirst($actionReferenceKey);
             $varAttributes = array_intersect($this->varAttributes, array_keys($action->getCustomActionAttributes()));
+            if ($action->getType() === ActionObject::ACTION_TYPE_HELPER) {
+                $varAttributes = array_keys($action->getCustomActionAttributes());
+            }
 
             // replace createDataKey attributes inside the action group
             $resolvedActionAttributes = $this->replaceCreateDataKeys($action, $replacementStepKeys);