MQE-1157: Add readiness bypass to test actions

aljcalandra · aljcalandra · commit 6b919a7b2473 · 2018-08-21T13:31:29.000-05:00
- Adding action to readiness skip list
- Adjusting conditional to check string match
diff --git a/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php b/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php
@@ -43,6 +43,7 @@ class PageReadinessExtension extends Extension
      */
     private $ignoredActions = [
         'saveScreenshot',
+        'skipReadinessCheck',
         'wait'
     ];
 
diff --git a/src/Magento/FunctionalTestingFramework/Test/Util/ActionMergeUtil.php b/src/Magento/FunctionalTestingFramework/Test/Util/ActionMergeUtil.php
@@ -232,7 +232,7 @@ private function insertReadinessSkips()
     {
         foreach ($this->orderedSteps as $step) {
             if (array_key_exists("skipReadiness", $step->getCustomActionAttributes())) {
-                if ($step->getCustomActionAttributes()['skipReadiness']) {
+                if ($step->getCustomActionAttributes()['skipReadiness'] == "true") {
                     $skipReadinessOn = new ActionObject(
                         $step->getStepKey() . self::SKIP_READINESS_ON_SUFFIX,
                         self::SKIP_READINESS_ACTION_NAME,

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ private function insertReadinessSkips()`
`232`	`232`	`{`
`233`	`233`	`foreach ($this->orderedSteps as $step) {`
`234`	`234`	`if (array_key_exists("skipReadiness", $step->getCustomActionAttributes())) {`
`235`		`- if ($step->getCustomActionAttributes()['skipReadiness']) {`
	`235`	`+ if ($step->getCustomActionAttributes()['skipReadiness'] == "true") {`
`236`	`236`	`$skipReadinessOn = new ActionObject(`
`237`	`237`	`$step->getStepKey() . self::SKIP_READINESS_ON_SUFFIX,`
`238`	`238`	`self::SKIP_READINESS_ACTION_NAME,`