Skip to content

Commit 40465e8

Browse files
committed
MQE-498: Ability to pass simple values into an action group
- Additional Test Case added to verification test.
1 parent cce66c4 commit 40465e8

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

dev/tests/verification/Resources/ActionGroupWithSimpleDataUsageFromPassedArgument.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,7 @@ class ActionGroupWithSimpleDataUsageFromPassedArgumentCest
3737
$I->see($persisted->getCreatedDataByName('data'), "#element ." . $persisted->getCreatedDataByName('data'));
3838
$I->see("John", "#element .John");
3939
$I->see($simpleData->getCreatedDataByName('firstname'), "#element ." . $simpleData->getCreatedDataByName('firstname'));
40+
$I->see($simpleData->getCreatedDataByName('firstname[0]'), "#element ." . $simpleData->getCreatedDataByName('firstname[0]'));
41+
$I->see($simpleData->getCreatedDataByName('firstname[data_index]'), "#element ." . $simpleData->getCreatedDataByName('firstname[data_index]'));
4042
}
4143
}

dev/tests/verification/TestModule/Test/ActionGroupTest.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,15 @@
9292
<actionGroup ref="actionGroupWithEntityUsage" stepKey="actionGroup4">
9393
<argument name="someArgument" value="simpleData.firstname"/>
9494
</actionGroup>
95-
<actionGroup ref="actionGroupWithStringUsage" stepKey="actionGroup5">
95+
<actionGroup ref="actionGroupWithEntityUsage" stepKey="actionGroup5">
9696
<argument name="someArgument" value="$simpleData.firstname$"/>
9797
</actionGroup>
98+
<actionGroup ref="actionGroupWithEntityUsage" stepKey="actionGroup6">
99+
<argument name="someArgument" value="$simpleData.firstname[0]$"/>
100+
</actionGroup>
101+
<actionGroup ref="actionGroupWithEntityUsage" stepKey="actionGroup7">
102+
<argument name="someArgument" value="$simpleData.firstname[data_index]$"/>
103+
</actionGroup>
98104
</test>
99105

100106
<test name="ActionGroupWithSimpleDataUsageFromDefaultArgument">

src/Magento/FunctionalTestingFramework/Test/Objects/ActionGroupObject.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ private function replaceAttributeArgumentInVariable(
236236
);
237237
}
238238

239-
$isPersisted = preg_match('/\$[\w.]+\$/', $matchedArgument->getResolvedValue($isInnerArgument));
239+
$isPersisted = preg_match('/\$[\w.\[\]() ]+\$/', $matchedArgument->getResolvedValue($isInnerArgument));
240240
if ($isPersisted) {
241241
return $this->replacePersistedArgument(
242242
$matchedArgument->getResolvedValue($isInnerArgument),

0 commit comments

Comments
 (0)