Skip to content

Commit 01f0847

Browse files
jilu1jilu1
committed
MQE-1379: Fix MFTF custom actions to fully support Codeception dry-run functionality
1 parent 29f770c commit 01f0847

File tree

2 files changed

+7
-126
lines changed

2 files changed

+7
-126
lines changed

‎src/Magento/FunctionalTestingFramework/Module/MagentoActionProxies.php

+1-120
Original file line numberDiff line numberDiff line change
@@ -20,124 +20,5 @@
2020
*/
2121
class MagentoActionProxies extends CodeceptionModule
2222
{
23-
/**
24-
* Create an entity
25-
* TODO: un-comment this function after MQE-1904
26-
*
27-
* @param string $key StepKey of the createData action.
28-
* @param string $scope
29-
* @param string $entity Name of xml entity to create.
30-
* @param array $dependentObjectKeys StepKeys of other createData actions that are required.
31-
* @param array $overrideFields Array of FieldName => Value of override fields.
32-
* @param string $storeCode
33-
* @return void
34-
*/
35-
/*
36-
public function createEntity(
37-
$key,
38-
$scope,
39-
$entity,
40-
$dependentObjectKeys = [],
41-
$overrideFields = [],
42-
$storeCode = ''
43-
) {
44-
PersistedObjectHandler::getInstance()->createEntity(
45-
$key,
46-
$scope,
47-
$entity,
48-
$dependentObjectKeys,
49-
$overrideFields,
50-
$storeCode
51-
);
52-
}
53-
*/
54-
/**
55-
* Retrieves and updates a previously created entity
56-
* TODO: un-comment this function after MQE-1904
57-
*
58-
* @param string $key StepKey of the createData action.
59-
* @param string $scope
60-
* @param string $updateEntity Name of the static XML data to update the entity with.
61-
* @param array $dependentObjectKeys StepKeys of other createData actions that are required.
62-
* @return void
63-
*/
64-
/*
65-
public function updateEntity($key, $scope, $updateEntity, $dependentObjectKeys = [])
66-
{
67-
PersistedObjectHandler::getInstance()->updateEntity(
68-
$key,
69-
$scope,
70-
$updateEntity,
71-
$dependentObjectKeys
72-
);
73-
}
74-
*/
75-
/**
76-
* Performs GET on given entity and stores entity for use
77-
* TODO: un-comment this function after MQE-1904
78-
*
79-
* @param string $key StepKey of getData action.
80-
* @param string $scope
81-
* @param string $entity Name of XML static data to use.
82-
* @param array $dependentObjectKeys StepKeys of other createData actions that are required.
83-
* @param string $storeCode
84-
* @param integer $index
85-
* @return void
86-
*/
87-
/*
88-
public function getEntity($key, $scope, $entity, $dependentObjectKeys = [], $storeCode = '', $index = null)
89-
{
90-
PersistedObjectHandler::getInstance()->getEntity(
91-
$key,
92-
$scope,
93-
$entity,
94-
$dependentObjectKeys,
95-
$storeCode,
96-
$index
97-
);
98-
}
99-
*/
100-
/**
101-
* Retrieves and deletes a previously created entity
102-
* TODO: un-comment this function after MQE-1904
103-
*
104-
* @param string $key StepKey of the createData action.
105-
* @param string $scope
106-
* @return void
107-
*/
108-
/*
109-
public function deleteEntity($key, $scope)
110-
{
111-
PersistedObjectHandler::getInstance()->deleteEntity($key, $scope);
112-
}
113-
*/
114-
/**
115-
* Retrieves a field from an entity, according to key and scope given
116-
* TODO: un-comment this function after MQE-1904
117-
*
118-
* @param string $stepKey
119-
* @param string $field
120-
* @param string $scope
121-
* @return string
122-
*/
123-
/*
124-
public function retrieveEntityField($stepKey, $field, $scope)
125-
{
126-
return PersistedObjectHandler::getInstance()->retrieveEntityField($stepKey, $field, $scope);
127-
}
128-
*/
129-
/**
130-
* Get encrypted value by key
131-
* TODO: un-comment this function after MQE-1904
132-
*
133-
* @param string $key
134-
* @return string|null
135-
* @throws TestFrameworkException
136-
*/
137-
/*
138-
public function getSecret($key)
139-
{
140-
return CredentialStore::getInstance()->getSecret($key);
141-
}
142-
*/
23+
// TODO: placeholder for proxy functions currently in MagentoWebDriver (MQE-1904)
14324
}

‎src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,7 @@ private function curlExecMagentoCLI($command, $timeout, $arguments): string
909909

910910
/**
911911
* Create an entity
912-
* TODO: remove this function after MQE-1904
912+
* TODO: move this function to MagentoActionProxies after MQE-1904
913913
*
914914
* @param string $key StepKey of the createData action.
915915
* @param string $scope
@@ -939,7 +939,7 @@ public function createEntity(
939939

940940
/**
941941
* Retrieves and updates a previously created entity
942-
* TODO: remove this function after MQE-1904
942+
* TODO: move this function to MagentoActionProxies after MQE-1904
943943
*
944944
* @param string $key StepKey of the createData action.
945945
* @param string $scope
@@ -959,7 +959,7 @@ public function updateEntity($key, $scope, $updateEntity, $dependentObjectKeys =
959959

960960
/**
961961
* Performs GET on given entity and stores entity for use
962-
* TODO: remove this function after MQE-1904
962+
* TODO: move this function to MagentoActionProxies after MQE-1904
963963
*
964964
* @param string $key StepKey of getData action.
965965
* @param string $scope
@@ -983,7 +983,7 @@ public function getEntity($key, $scope, $entity, $dependentObjectKeys = [], $sto
983983

984984
/**
985985
* Retrieves and deletes a previously created entity
986-
* TODO: remove this function after MQE-1904
986+
* TODO: move this function to MagentoActionProxies after MQE-1904
987987
*
988988
* @param string $key StepKey of the createData action.
989989
* @param string $scope
@@ -996,7 +996,7 @@ public function deleteEntity($key, $scope)
996996

997997
/**
998998
* Retrieves a field from an entity, according to key and scope given
999-
* TODO: remove this function after MQE-1904
999+
* TODO: move this function to MagentoActionProxies after MQE-1904
10001000
*
10011001
* @param string $stepKey
10021002
* @param string $field
@@ -1010,7 +1010,7 @@ public function retrieveEntityField($stepKey, $field, $scope)
10101010

10111011
/**
10121012
* Get encrypted value by key
1013-
* TODO: remove this function after MQE-1904
1013+
* TODO: move this function to MagentoActionProxies after MQE-1904
10141014
*
10151015
* @param string $key
10161016
* @return string|null

0 commit comments

Comments
 (0)