-
Notifications
You must be signed in to change notification settings - Fork 132
/
Copy pathDuplicateStepKeysCheck.php
213 lines (198 loc) · 7.15 KB
/
DuplicateStepKeysCheck.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
namespace Magento\FunctionalTestingFramework\StaticCheck;
use Magento\FunctionalTestingFramework\Config\MftfApplicationConfig;
use InvalidArgumentException;
use Exception;
use Magento\FunctionalTestingFramework\Exceptions\TestFrameworkException;
use Magento\FunctionalTestingFramework\Exceptions\XmlException;
use Magento\FunctionalTestingFramework\Page\Objects\SectionObject;
use Magento\FunctionalTestingFramework\Test\Objects\ActionObject;
use Magento\FunctionalTestingFramework\Page\Objects\ElementObject;
use Magento\FunctionalTestingFramework\Test\Objects\ActionGroupObject;
use Magento\FunctionalTestingFramework\Page\Objects\PageObject;
use Magento\FunctionalTestingFramework\Test\Objects\TestObject;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Finder\Finder;
use Magento\FunctionalTestingFramework\Util\Script\ScriptUtil;
use Magento\FunctionalTestingFramework\DataGenerator\Handlers\OperationDefinitionObjectHandler;
use Magento\FunctionalTestingFramework\DataGenerator\Objects\OperationDefinitionObject;
use Magento\FunctionalTestingFramework\DataGenerator\Handlers\DataObjectHandler;
use Magento\FunctionalTestingFramework\DataGenerator\Objects\EntityDataObject;
use Symfony\Component\Finder\SplFileInfo;
use DOMNodeList;
use DOMElement;
/**
* Class CreatedDataFromOutsideActionGroupCheck
* @package Magento\FunctionalTestingFramework\StaticCheck
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class DuplicateStepKeysCheck implements StaticCheckInterface
{
const ERROR_LOG_FILENAME = 'duplicate-step-keys';
const ERROR_LOG_MESSAGE = 'Duplicate Step Key Check';
const STEP_KEY_REGEX_PATTERN = '/stepKey=["\']([^\'"]*)/';
/**
* Array containing all errors found after running the execute() function
*
* @var array
*/
private $errors = [];
/**
* String representing the output summary found after running the execute() function
*
* @var string
*/
private $output;
/**
* ScriptUtil instance
*
* @var ScriptUtil
*/
private $scriptUtil;
/**
* Checks test dependencies, determined by references in tests versus the
* dependencies listed in the Magento module
*
* @param InputInterface $input
* @return void
* @throws Exception
*/
public function execute(InputInterface $input)
{
$this->scriptUtil = new ScriptUtil();
$this->loadAllXmlFiles($input);
$this->errors += $this->findReferenceErrorsInFiles($this->actionGroupXmlFile);
// hold on to the output and print any errors to a file
$this->output = $this->scriptUtil->printErrorsToFile(
$this->errors,
StaticChecksList::getErrorFilesPath() . DIRECTORY_SEPARATOR . self::ERROR_LOG_FILENAME . '.txt',
self::ERROR_LOG_MESSAGE
);
}
/**
* Return array containing all errors found after running the execute() function
*
* @return array
*/
public function getErrors()
{
return $this->errors;
}
/**
* Return string of a short human readable result of the check. For example: "No Dependency errors found."
*
* @return string
*/
public function getOutput()
{
return $this->output;
}
/**
* Read all XML files for scanning
*
* @param InputInterface $input
* @return void
* @throws Exception
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
private function loadAllXmlFiles($input)
{
$modulePaths = [];
$path = $input->getOption('path');
if ($path) {
if (!realpath($path)) {
throw new InvalidArgumentException('Invalid --path option: ' . $path);
}
MftfApplicationConfig::create(
true,
MftfApplicationConfig::UNIT_TEST_PHASE,
false,
MftfApplicationConfig::LEVEL_DEFAULT,
true
);
$modulePaths[] = realpath($path);
} else {
$modulePaths = $this->scriptUtil->getAllModulePaths();
}
// These files can contain references to other entities
$this->actionGroupXmlFile = $this->scriptUtil->getModuleXmlFilesByScope($modulePaths, 'ActionGroup');
$this->testXmlFiles = $this->scriptUtil->getModuleXmlFilesByScope($modulePaths, 'Test');
$this->suiteXmlFiles = $this->scriptUtil->getModuleXmlFilesByScope($modulePaths, 'Suite');
if (empty($this->actionGroupXmlFile)) {
if ($path) {
throw new InvalidArgumentException(
'Invalid --path option: '
. $path
. PHP_EOL
. 'Please make sure --path points to a valid MFTF Test Module.'
);
} elseif (empty($this->rootSuiteXmlFiles)) {
throw new TestFrameworkException('No xml file to scan.');
}
}
}
/**
* Find reference errors in set of action files
*
* @param Finder $files
* @return array
* @throws XmlException
*/
private function findReferenceErrorsInFiles($files)
{
$testErrors = [];
/** @var SplFileInfo $filePath */
foreach ($files as $filePath) {
$actionGroupReferencesDataArray = [];
$contents = file_get_contents($filePath);
preg_match_all(self::STEP_KEY_REGEX_PATTERN, $contents, $actionGroupReferences);
foreach ($actionGroupReferences[0] as $actionGroupReferencesData) {
$actionGroupReferencesDataArray[] = trim(
str_replace(
['stepKey', '='],
[""],
$actionGroupReferencesData
)
).'"';
}
$duplicateStepKeys = array_unique(
array_diff_assoc(
$actionGroupReferencesDataArray,
array_unique(
$actionGroupReferencesDataArray
)
)
);
unset($actionGroupReferencesDataArray);
if (isset($duplicateStepKeys) && count($duplicateStepKeys) > 0) {
$testErrors = array_merge($testErrors, $this->setErrorOutput($duplicateStepKeys, $filePath));
}
}
return $testErrors;
}
/**
* Build and return error output for violating references
*
* @param array $violatingReferences
* @param SplFileInfo $path
* @return mixed
*/
private function setErrorOutput($violatingReferences, $path)
{
$testErrors = [];
$filePath = StaticChecksList::getFilePath($path->getRealPath());
if (!empty($violatingReferences)) {
// Build error output
$errorOutput = "\nFile \"{$filePath}\"";
foreach ($violatingReferences as $stepKey) {
$errorOutput .= "\n\t has duplicate stepKey(s): ". $stepKey;
}
$testErrors[$filePath][] = $errorOutput;
}
return $testErrors;
}
}