Added support for wikimedia/less.php 5.0

djadobe16 · djadobe16 · commit 0ef7e6e4e054 · 2025-01-17T18:54:13.000+05:30
diff --git a/dev/tests/Unit/Console/Command/CompareSourceCommandLessTest.php b/dev/tests/Unit/Console/Command/CompareSourceCommandLessTest.php
@@ -98,7 +98,7 @@ public static function changesDataProvider()
                 $pathToFixtures . '/removed-import/source-code-after',
                 [
                     '/Less \(MAJOR\)/',
-                    '/view\/frontend\/web\/css\/source\/test.less:0\s*\|\s*Import with value: \'testimport\'\s*\|\s*A less import-node was removed\s*\|\s*M402/'
+                    '/view\/frontend\/web\/css\/source\/test.less:0\s*\|\s*Less_Tree_Import\s*\|\s*A less import-node was removed\s*\|\s*M402/'
                 ],
                 'Major change is detected.',
             ],
@@ -107,8 +107,8 @@ public static function changesDataProvider()
                 $pathToFixtures . '/removed-imports/source-code-after',
                 [
                     '/Less \(MAJOR\)/',
-                    '/view\/frontend\/web\/css\/source\/test.less:0\s*\|\s*Import with value: \'testimport\'\s*\|\s*A less import-node was removed\s*\|\s*M402/',
-                    '/view\/frontend\/web\/css\/source\/test.less:0\s*\|\s*Import with value: \'testimport2\'\s*\|\s*A less import-node was removed\s*\|\s*M402/'
+                    '/view\/frontend\/web\/css\/source\/test.less:0\s*\|\s*Less_Tree_Import\s*\|\s*A less import-node was removed\s*\|\s*M402/',
+                    '/view\/frontend\/web\/css\/source\/test.less:0\s*\|\s*Less_Tree_Import\s*\|\s*A less import-node was removed\s*\|\s*M402/'
                 ],
                 'Major change is detected.',
             ],
diff --git a/dev/tests/Unit/Console/Command/CompareSourceCommandTest/_files/api-class/new-optional-constructor-parameter-for-extendable/source-code-after/AbstractExtensibleModel.php b/dev/tests/Unit/Console/Command/CompareSourceCommandTest/_files/api-class/new-optional-constructor-parameter-for-extendable/source-code-after/AbstractExtensibleModel.php
@@ -11,7 +11,7 @@
  */
 class AbstractExtensibleModel
 {
-    public function __construct(\Test\Vcs\TestInterface $a, \Test\Vcs\TestInterface $b = null)
+    public function __construct(\Test\Vcs\TestInterface $a, ?\Test\Vcs\TestInterface $b = null)
     {
     }
 }
diff --git a/dev/tests/Unit/Console/Command/CompareSourceCommandTest/_files/api-class/new-optional-constructor-parameter/source-code-after/TestClass.php b/dev/tests/Unit/Console/Command/CompareSourceCommandTest/_files/api-class/new-optional-constructor-parameter/source-code-after/TestClass.php
@@ -11,7 +11,7 @@
  */
 class TestClass
 {
-    public function __construct(\Test\Vcs\TestInterface $a, \Test\Vcs\TestInterface $b = null)
+    public function __construct(\Test\Vcs\TestInterface $a, ?\Test\Vcs\TestInterface $b = null)
     {
     }
 }
diff --git a/dev/tests/Unit/Console/Command/CompareSourceCommandTest/_files/non-api-class/new-optional-constructor-parameter/source-code-after/TestClass.php b/dev/tests/Unit/Console/Command/CompareSourceCommandTest/_files/non-api-class/new-optional-constructor-parameter/source-code-after/TestClass.php
@@ -8,7 +8,7 @@
 
 class TestClass
 {
-    public function __construct(\Test\Vcs\TestInterface $a, \Test\Vcs\TestInterface $b = null)
+    public function __construct(\Test\Vcs\TestInterface $a, ?\Test\Vcs\TestInterface $b = null)
     {
     }
 }
diff --git a/src/Analyzer/AbstractCodeAnalyzer.php b/src/Analyzer/AbstractCodeAnalyzer.php
@@ -51,7 +51,7 @@ public function __construct(
         $context = null,
         $fileBefore = null,
         $fileAfter = null,
-        DependencyGraph $dependencyGraph = null
+        ?DependencyGraph $dependencyGraph = null
     ) {
         $this->context = $context;
         $this->fileBefore = $fileBefore;
diff --git a/src/Analyzer/ClassLikeApiAnnotationAnalyzer.php b/src/Analyzer/ClassLikeApiAnnotationAnalyzer.php
@@ -35,7 +35,7 @@ public function __construct(
         $context = null,
         $fileBefore = null,
         $fileAfter = null,
-        DependencyGraph $dependencyGraph = null
+        ?DependencyGraph $dependencyGraph = null
     ) {
         parent::__construct($context, $fileBefore, $fileAfter, $dependencyGraph);
         $this->nodeHelper = new Node();
diff --git a/src/Analyzer/Factory/AnalyzerFactory.php b/src/Analyzer/Factory/AnalyzerFactory.php
@@ -25,7 +25,7 @@ class AnalyzerFactory implements AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $analyzers = [
             new ApiClassAnalyzer(null, null, null, $dependencyGraph),
diff --git a/src/Analyzer/Factory/AnalyzerFactoryInterface.php b/src/Analyzer/Factory/AnalyzerFactoryInterface.php
@@ -21,5 +21,5 @@ interface AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface;
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface;
 }
diff --git a/src/Analyzer/Factory/DbSchemaAnalyzerFactory.php b/src/Analyzer/Factory/DbSchemaAnalyzerFactory.php
@@ -30,7 +30,7 @@ class DbSchemaAnalyzerFactory implements AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $report = new Report();
         $analyzers = [
diff --git a/src/Analyzer/Factory/DiAnalyzerFactory.php b/src/Analyzer/Factory/DiAnalyzerFactory.php
@@ -24,7 +24,7 @@ class DiAnalyzerFactory implements AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $report = new DbSchemaReport();
         $analyzers = [
diff --git a/src/Analyzer/Factory/EtSchemaAnalyzerFactory.php b/src/Analyzer/Factory/EtSchemaAnalyzerFactory.php
@@ -22,7 +22,7 @@
  */
 class EtSchemaAnalyzerFactory implements AnalyzerFactoryInterface
 {
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $report = new DbSchemaReport();
         $analyzers = [
diff --git a/src/Analyzer/Factory/LayoutAnalyzerFactory.php b/src/Analyzer/Factory/LayoutAnalyzerFactory.php
@@ -24,7 +24,7 @@ class LayoutAnalyzerFactory implements AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $report = new DbSchemaReport();
         $analyzers = [
diff --git a/src/Analyzer/Factory/LessAnalyzerFactory.php b/src/Analyzer/Factory/LessAnalyzerFactory.php
@@ -24,7 +24,7 @@ class LessAnalyzerFactory implements AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $report    = new DbSchemaReport();
         $analyzers = [
diff --git a/src/Analyzer/Factory/MftfAnalyzerFactory.php b/src/Analyzer/Factory/MftfAnalyzerFactory.php
@@ -30,7 +30,7 @@ class MftfAnalyzerFactory implements AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $report = new MftfReport();
         $analyzers = [
diff --git a/src/Analyzer/Factory/NonApiAnalyzerFactory.php b/src/Analyzer/Factory/NonApiAnalyzerFactory.php
@@ -25,7 +25,7 @@ class NonApiAnalyzerFactory implements AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $analyzers = [
             new ClassAnalyzer(null, null, null, $dependencyGraph),
diff --git a/src/Analyzer/Factory/SystemXmlAnalyzerFactory.php b/src/Analyzer/Factory/SystemXmlAnalyzerFactory.php
@@ -24,7 +24,7 @@ class SystemXmlAnalyzerFactory implements AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $report = new DbSchemaReport();
         $analyzers = [
diff --git a/src/Analyzer/Factory/XsdAnalyzerFactory.php b/src/Analyzer/Factory/XsdAnalyzerFactory.php
@@ -24,7 +24,7 @@ class XsdAnalyzerFactory implements AnalyzerFactoryInterface
      * @param DependencyGraph|null $dependencyGraph
      * @return AnalyzerInterface
      */
-    public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface
+    public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface
     {
         $report    = new DbSchemaReport();
         $analyzers = [
diff --git a/src/Analyzer/Less/Analyzer.php b/src/Analyzer/Less/Analyzer.php
@@ -20,7 +20,7 @@
 use PHPSemVerChecker\Report\Report;
 use Less_Tree;
 use Less_Tree_Comment;
-use Less_Tree_Rule;
+use Less_Tree_Declaration;
 use Less_Tree_Mixin_Definition;
 use Less_Tree_Import;
 
@@ -152,7 +152,7 @@ private function reportRemovedNodes(string $file, array $nodes)
     {
         foreach ($nodes as $nodeName => $node) {
             switch (true) {
-                case $node instanceof Less_Tree_Rule:
+                case $node instanceof Less_Tree_Declaration:
                     $this->report->add(self::CONTEXT, new VariableRemoved($file, $nodeName));
                     break;
                 case $node instanceof Less_Tree_Mixin_Definition:
diff --git a/src/Scanner/ScannerRegistryFactory.php b/src/Scanner/ScannerRegistryFactory.php
@@ -55,8 +55,8 @@ private function buildFullScanner()
      * @return Scanner
      */
     private function buildApiScanner(
-        DependencyGraph $dependencyGraph = null,
-        DependencyGraph $dependencyGraphCompare = null
+        ?DependencyGraph $dependencyGraph = null,
+        ?DependencyGraph $dependencyGraphCompare = null
     ) {
         $registry    = new Registry();
         $parser      = new Parser(new Emulative());
@@ -80,7 +80,7 @@ private function buildApiScanner(
      * @param boolean              $mftf
      * @return array
      */
-    public function create(DependencyGraph $dependencyGraph = null, DependencyGraph $dependencyGraphCompare = null)
+    public function create(?DependencyGraph $dependencyGraph = null, ?DependencyGraph $dependencyGraphCompare = null)
     {
         $moduleNameResolver = new ModuleNamespaceResolver();
 
diff --git a/src/Visitor/AbstractApiVisitor.php b/src/Visitor/AbstractApiVisitor.php
@@ -40,8 +40,8 @@ abstract class AbstractApiVisitor extends NodeVisitorAbstract
     public function __construct(
         Registry $registry,
         NodeHelper $nodeHelper,
-        DependencyGraph $dependencyGraph = null,
-        DependencyGraph $dependencyGraphCompare = null
+        ?DependencyGraph $dependencyGraph = null,
+        ?DependencyGraph $dependencyGraphCompare = null
     ) {
         $this->dependencyGraph        = $dependencyGraph;
         $this->dependencyGraphComapre = $dependencyGraphCompare;

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`*/`
`12`	`12`	`class AbstractExtensibleModel`
`13`	`13`	`{`
`14`		`- public function __construct(\Test\Vcs\TestInterface $a, \Test\Vcs\TestInterface $b = null)`
	`14`	`+ public function __construct(\Test\Vcs\TestInterface $a, ?\Test\Vcs\TestInterface $b = null)`
`15`	`15`	`{`
`16`	`16`	`}`
`17`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`
`9`	`9`	`class TestClass`
`10`	`10`	`{`
`11`		`- public function __construct(\Test\Vcs\TestInterface $a, \Test\Vcs\TestInterface $b = null)`
	`11`	`+ public function __construct(\Test\Vcs\TestInterface $a, ?\Test\Vcs\TestInterface $b = null)`
`12`	`12`	`{`
`13`	`13`	`}`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class AnalyzerFactory implements AnalyzerFactoryInterface`
`25`	`25`	`* @param DependencyGraph\|null $dependencyGraph`
`26`	`26`	`* @return AnalyzerInterface`
`27`	`27`	`*/`
`28`		`- public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface`
	`28`	`+ public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface`
`29`	`29`	`{`
`30`	`30`	`$analyzers = [`
`31`	`31`	`new ApiClassAnalyzer(null, null, null, $dependencyGraph),`
Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,5 @@ interface AnalyzerFactoryInterface`
`21`	`21`	`* @param DependencyGraph\|null $dependencyGraph`
`22`	`22`	`* @return AnalyzerInterface`
`23`	`23`	`*/`
`24`		`- public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface;`
	`24`	`+ public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface;`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class DbSchemaAnalyzerFactory implements AnalyzerFactoryInterface`
`30`	`30`	`* @param DependencyGraph\|null $dependencyGraph`
`31`	`31`	`* @return AnalyzerInterface`
`32`	`32`	`*/`
`33`		`- public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface`
	`33`	`+ public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface`
`34`	`34`	`{`
`35`	`35`	`$report = new Report();`
`36`	`36`	`$analyzers = [`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class DiAnalyzerFactory implements AnalyzerFactoryInterface`
`24`	`24`	`* @param DependencyGraph\|null $dependencyGraph`
`25`	`25`	`* @return AnalyzerInterface`
`26`	`26`	`*/`
`27`		`- public function create(DependencyGraph $dependencyGraph = null): AnalyzerInterface`
	`27`	`+ public function create(?DependencyGraph $dependencyGraph = null): AnalyzerInterface`
`28`	`28`	`{`
`29`	`29`	`$report = new DbSchemaReport();`
`30`	`30`	`$analyzers = [`