ACP2E-1919: Implement sniff that reports usage of dynamic properties as deprecated

Author: bubasuma

Magento2/Internal/Cache.php

@@ -0,0 +1,87 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento2\Internal;
+
+use PHP_CodeSniffer\Files\File;
+
+/**
+ * Wrapper for \PHPCSUtils\Internal\Cache
+ *
+ * @see \PHPCSUtils\Internal\Cache
+ * @internal
+ */
+final class Cache
+{
+    /**
+     * Wrapper for \PHPCSUtils\Internal\Cache::isCached() method.
+     *
+     * @param \PHP_CodeSniffer\Files\File $phpcsFile
+     * @param string $key
+     * @param int|string $id
+     *
+     * @return bool
+     * @see \PHPCSUtils\Internal\Cache::isCached()
+     */
+    public static function isCached(File $phpcsFile, $key, $id)
+    {
+        return \PHPCSUtils\Internal\Cache::isCached($phpcsFile, $key, $id);
+    }
+
+    /**
+     * Wrapper for \PHPCSUtils\Internal\Cache::get() method.
+     *
+     * @param \PHP_CodeSniffer\Files\File $phpcsFile
+     * @param string $key
+     * @param int|string $id
+     *
+     * @return mixed
+     * @see \PHPCSUtils\Internal\Cache::get()
+     */
+    public static function get(File $phpcsFile, $key, $id)
+    {
+        return \PHPCSUtils\Internal\Cache::get($phpcsFile, $key, $id);
+    }
+
+    /**
+     * Wrapper for \PHPCSUtils\Internal\Cache::getForFile() method.
+     *
+     * @param \PHP_CodeSniffer\Files\File $phpcsFile
+     * @param string $key
+     * @return array
+     * @see \PHPCSUtils\Internal\Cache::getForFile()
+     */
+    public static function getForFile(File $phpcsFile, $key)
+    {
+        return \PHPCSUtils\Internal\Cache::getForFile($phpcsFile, $key);
+    }
+
+    /**
+     * Wrapper for \PHPCSUtils\Internal\Cache::set() method.
+     *
+     * @param \PHP_CodeSniffer\Files\File $phpcsFile
+     * @param string $key
+     * @param int|string $id
+     * @param mixed $value
+     * @return void
+     * @see \PHPCSUtils\Internal\Cache::set()
+     */
+    public static function set(File $phpcsFile, $key, $id, $value)
+    {
+        \PHPCSUtils\Internal\Cache::set($phpcsFile, $key, $id, $value);
+    }
+
+    /**
+     * Wrapper for \PHPCSUtils\Internal\Cache::clear() method.
+     *
+     * @return void
+     * @see \PHPCSUtils\Internal\Cache::clear()
+     */
+    public static function clear()
+    {
+        \PHPCSUtils\Internal\Cache::clear();
+    }
+}

Magento2/Rector/Src/ReplacePregSplitNullLimit.php

@@ -8,8 +8,8 @@
 namespace Magento2\Rector\Src;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
-use PhpParser\Node\Scalar\LNumber;
 use Rector\Core\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -29,11 +29,12 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if (!$this->isName($node->name, 'preg_split')) {
+        if (!$this->isName($node->name, 'preg_split') || !isset($node->args[2])) {
             return null;
         }
+        $value = $node->args[2]->value;
 
-        if ($node->args[2] !== LNumber::class) {
+        if ($value instanceof ConstFetch && $value->name->toString() === 'null') {
             $node->args[2] = $this->nodeFactory->createArg(-1);
             return $node;
         }

Magento2/Rector/Tests/ReplacePregSplitNullLimit/Fixture/replace_null.php.inc

@@ -1,11 +1,17 @@
 <?php
 
-preg_split('pattern', 'subject', null, 0)
+preg_split('pattern', 'subject', null, 0);
+preg_split('pattern', 'subject', 2);
+preg_split('pattern', 'subject', $var);
+preg_split('pattern', 'subject');
 
 ?>
 -----
 <?php
 
-preg_split('pattern', 'subject', -1, 0)
+preg_split('pattern', 'subject', -1, 0);
+preg_split('pattern', 'subject', 2);
+preg_split('pattern', 'subject', $var);
+preg_split('pattern', 'subject');
 
 ?>