AC-391: Static test to cover "deprecated" jQuery methods

- Fixed naming and comment issues

Author: Rrego6

Magento2/Tests/Eslint/MiscDeprecatedExprTest.js renamed to Magento2/Tests/Eslint/DeprecatedExprTest.js

@@ -8,16 +8,16 @@
 namespace Magento2\Tests\Eslint;
 
 /**
- * Class EventShorthandTest
+ * Class DeprecatedExprTest
  *
- * Test Eslint Rule: jquery-no-event-shorthand.js
+ * Test Eslint Rule: jquery-no-deprecated-expr.js
  */
-class MiscDeprecatedExprTest extends AbstractEslintTestCase
+class DeprecatedExprTest extends AbstractEslintTestCase
 {
     public function testExecute(): void
     {
         $this->assertFileContainsError(
-            'MiscDeprecatedExprTest.js',
+            'DeprecatedExprTest.js',
             [
                 'jQuery.expr[":"] is deprecated; Use jQuery.expr.pseudos instead',
                 'jQuery.expr.filters is deprecated; Use jQuery.expr.pseudos instead'

Magento2/Tests/Eslint/MiscDeprecatedExprTest.php renamed to Magento2/Tests/Eslint/DeprecatedExprTest.php

@@ -8,16 +8,16 @@
 namespace Magento2\Tests\Eslint;
 
 /**
- * Class ClickEventShorthandTest
+ * Class InputEventShorthandTest
  *
- * Test Eslint Rule: jquery-no-click-event-shorthand.js
+ * Test Eslint Rule: jquery-no-input-event-shorthand.js
  */
-class ClickEventShorthandTest extends AbstractEslintTestCase
+class InputEventShorthandTest extends AbstractEslintTestCase
 {
     public function testExecute(): void
     {
         $this->assertFileContainsError(
-            'ClickEventShorthandTest.js',
+            'InputEventShorthandTest.js',
             [
                 'Instead of .blur(fn) use .on("blur", fn). Instead of .blur() use .trigger("blur")',
                 'Instead of .focus(fn) use .on("focus", fn). Instead of .focus() use .trigger("focus")',

Magento2/Tests/Eslint/ClickEventShorthandTest.js renamed to Magento2/Tests/Eslint/InputEventShorthandTest.js

@@ -8,9 +8,9 @@
 namespace Magento2\Tests\Eslint;
 
 /**
- * Class EventShorthandTest
+ * Class MiscDeprecatedFunctionsTest
  *
- * Test Eslint Rule: jquery-no-event-shorthand.js
+ * Test Eslint Rule: jquery-no-misc-deprecated-functions.js
  */
 class MiscDeprecatedFunctionsTest extends AbstractEslintTestCase
 {

Magento2/Tests/Eslint/ClickEventShorthandTest.php renamed to Magento2/Tests/Eslint/InputEventShorthandTest.php

@@ -1,8 +1,9 @@
 {
+    "ignorePatterns": ["**/vendor/**/*.js", "**/node_modules/**/*.js"],
     "rules": {
         "jquery-no-andSelf": 2,
         "jquery-no-bind-unbind": 2,
-        "jquery-no-click-event-shorthand": 2,
+        "jquery-no-input-event-shorthand": 2,
         "jquery-no-delegate-undelegate": 2,
         "jquery-no-event-shorthand": 2,
         "jquery-no-size": 2,

Magento2/Tests/Eslint/MiscDeprecatedFunctionsTest.php

@@ -2,7 +2,7 @@ module.exports = {
     meta: {
         type: 'suggestion',
         docs: {
-            description: 'Disallow the use of shorthand event methods',
+            description: 'Disallow the use of deprecated way to add to custom selectors',
             category: 'jQuery deprecated functions',
             recommended: true,
             url: 'https://api.jquery.com/load/'
@@ -23,7 +23,7 @@ module.exports = {
 
         return {
             /**
-             * Checks if shorthand methods are used and reports it.
+             * Checks for jQuery.expr[':']
              *
              * @param {Object} node - The node to check.
              */
@@ -35,6 +35,12 @@ module.exports = {
                     });
                 }
             },
+
+            /**
+             * Checks for jQuery.expr.filters
+             *
+             * @param {Object} node - The node to check.
+             */
             'MemberExpression[property.name="filters"] MemberExpression[property.name="expr"]': function (node) {
                 if (utils.isjQuery(node)) {
                     context.report({

eslint/.eslintrc-jquery

@@ -44,7 +44,7 @@ module.exports = {
                 if (utils.isjQuery(node)) {
                     context.report({
                         node: node,
-                        message: namesToMsg[name]
+                        message: message
                     });
                 }
             }

eslint/rules/jquery-no-deprecated-expr.js

@@ -2,7 +2,7 @@ module.exports = {
     meta: {
         type: 'suggestion',
         docs: {
-            description: 'Disallow the use of shortcuts to trigger events',
+            description: 'Disallow the use of shortcuts to input events via keyboard/mouse trigger events',
             category: 'jQuery deprecated functions',
             recommended: true,
             url: 'https://api.jquery.com/bind/'

eslint/rules/jquery-no-event-shorthand.js

@@ -2,7 +2,7 @@ module.exports = {
     meta: {
         type: 'suggestion',
         docs: {
-            description: 'Disallow the use of shorthand event methods',
+            description: 'Disallow the use of various deprecated methods methods',
             category: 'jQuery deprecated functions',
             recommended: true,
             url: 'https://api.jquery.com/load/'
@@ -11,7 +11,7 @@ module.exports = {
     },
 
     /**
-     * Executes the function to check if shorthand methods are used.
+     * Executes the function to check if deprecated methods methods are used
      *
      * @param {Object} context
      * @returns {Object}
@@ -23,7 +23,7 @@ module.exports = {
 
         return {
             /**
-             * Checks if shorthand methods are used and reports it.
+             * Checks if deprecated methods are used and reports it.
              *
              * @param {Object} node - The node to check.
              */

eslint/rules/jquery-no-click-event-shorthand.js renamed to eslint/rules/jquery-no-input-event-shorthand.js

@@ -4,7 +4,7 @@
   "description": "",
   "main": "eslint/.eslintrc",
   "scripts": {
-    "eslint": "./node_modules/.bin/eslint -c eslint/.eslintrc --rulesdir eslint/rules"
+    "eslint": "./node_modules/.bin/eslint -c eslint/.eslintrc-jquery --rulesdir eslint/rules"
   },
   "author": "",
   "license": "ISC",