Skip to content

Commit 06ccb74

Browse files
committed
MQE-469: use 'number' for operation data type according to swagger 2.0 spec.
1 parent 93e5768 commit 06ccb74

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Persist/OperationDataArrayResolverTest.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ class OperationDataArrayResolverTest extends TestCase
2020
"name" => "Hopper",
2121
"address" => ["city" => "Hawkins", "state" => "Indiana", "zip" => 78758],
2222
"isPrimary" => true,
23-
"gpa" => 3.5,
23+
"gpa" => 3.5678,
2424
"phone" => 5555555
2525
]];
2626

2727
const NESTED_METADATA_ARRAY_RESULT = ["parentType" => [
2828
"name" => "Hopper",
2929
"isPrimary" => true,
30-
"gpa" => 3.5,
30+
"gpa" => 3.5678,
3131
"phone" => 5555555,
3232
"address" => [
3333
["city" => "Hawkins", "state" => "Indiana", "zip" => 78758],
@@ -65,7 +65,7 @@ public function testBasicPrimitiveMetadataResolve()
6565
// assert on result
6666
$expectedResult = ["testType" => [
6767
"name" => "Hopper",
68-
"gpa" => 3.5,
68+
"gpa" => 3.5678,
6969
"phone" => 5555555,
7070
"isPrimary" => true
7171
]];

dev/tests/unit/Util/EntityDataObjectBuilder.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class EntityDataObjectBuilder
1616
*/
1717
private $data = [
1818
"name" => "Hopper",
19-
"gpa" => "3.5",
19+
"gpa" => "3.5678",
2020
"phone" => "5555555",
2121
"isprimary" => "true"
2222
];

dev/tests/unit/Util/OperationElementBuilder.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class OperationElementBuilder
1818
*/
1919
private $fields = [
2020
'name' => 'string',
21-
'gpa' => 'double',
21+
'gpa' => 'number',
2222
'phone' => 'integer',
2323
'isPrimary' => 'boolean'
2424
];

src/Magento/FunctionalTestingFramework/DataGenerator/Persist/OperationDataArrayResolver.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class OperationDataArrayResolver
1818
'string',
1919
'boolean',
2020
'integer',
21-
'double'
21+
'number'
2222
];
2323
const EXCEPTION_REQUIRED_DATA = "%s of key \" %s\" in \"%s\" is required by metadata, but was not provided.";
2424

@@ -362,8 +362,8 @@ private function castValue($type, $value)
362362
}
363363
$newVal = (boolean)$value;
364364
break;
365-
case 'double':
366-
$newVal = (double)$value;
365+
case 'number':
366+
$newVal = (float)$value;
367367
break;
368368
}
369369

0 commit comments

Comments
 (0)