MAGETWO-55730: Remove support of v1 queue config

Author: Alex Paliarush

lib/internal/Magento/Framework/Communication/Config/ConfigParser.php

@@ -13,6 +13,9 @@
  */
 class ConfigParser
 {
+    const TYPE_NAME = 'typeName';
+    const METHOD_NAME = 'methodName';
+
     /**
      * Parse service method name.
      *
@@ -34,6 +37,6 @@ public function parseServiceMethod($serviceMethod)
         }
         $className = $matches[1];
         $methodName = $matches[2];
-        return ['type' => $className, 'method' => $methodName];
+        return [self::TYPE_NAME => $className, self::METHOD_NAME => $methodName];
     }
 }

lib/internal/Magento/Framework/Communication/Config/Reader/XmlReader/Converter.php

@@ -106,8 +106,8 @@ protected function extractTopics($config)
             $serviceMethod = $this->getServiceMethodBySchema($topicNode);
             $requestResponseSchema = $serviceMethod
                 ? $this->reflectionGenerator->extractMethodMetadata(
-                    $serviceMethod['type'],
-                    $serviceMethod['method']
+                    $serviceMethod[ConfigParser::TYPE_NAME],
+                    $serviceMethod[ConfigParser::METHOD_NAME]
                 )
                 : null;
             $requestSchema = $this->extractTopicRequestSchema($topicNode);
@@ -129,8 +129,8 @@ protected function extractTopics($config)
             if ($serviceMethod) {
                 $output[$topicName] = $this->reflectionGenerator->generateTopicConfigForServiceMethod(
                     $topicName,
-                    $serviceMethod['type'],
-                    $serviceMethod['method'],
+                    $serviceMethod[ConfigParser::TYPE_NAME],
+                    $serviceMethod[ConfigParser::METHOD_NAME],
                     $handlers
                 );
             } else if ($requestSchema && $responseSchema) {
@@ -239,12 +239,24 @@ protected function getServiceMethodBySchema($topicNode)
         }
         $topicName = $topicAttributes->getNamedItem('name')->nodeValue;
         $serviceMethod = $topicAttributes->getNamedItem('schema')->nodeValue;
+        return $this->parseServiceMethod($serviceMethod, $topicName);
+    }
+
+    /**
+     * Parse service method name, also ensure that it exists.
+     *
+     * @param string $serviceMethod
+     * @param string $topicName
+     * @return array Contains class name and method name
+     */
+    protected function parseServiceMethod($serviceMethod, $topicName)
+    {
         $parsedServiceMethod = $this->getConfigParser()->parseServiceMethod($serviceMethod);
         $this->xmlValidator->validateServiceMethod(
             $serviceMethod,
             $topicName,
-            $parsedServiceMethod['type'],
-            $parsedServiceMethod['method']
+            $parsedServiceMethod[ConfigParser::TYPE_NAME],
+            $parsedServiceMethod[ConfigParser::METHOD_NAME]
         );
         return $parsedServiceMethod;
     }