MAGETWO-52667: CLI unaffected by permissions configuration setting in server config [develop branch]

 - use magento_umask file to store custom umask

Author: dsikkema-magento

.htaccess

@@ -4,12 +4,6 @@
 
 #   SetEnv MAGE_MODE developer
 
-############################################
-## overrides default umask value to allow using different
-## file permissions
-
-#   SetEnv MAGE_UMASK 022
-
 ############################################
 ## uncomment these lines for CGI mode
 ## make sure to specify the correct cgi php binary file name
@@ -281,6 +275,10 @@
         order allow,deny
         deny from all
     </Files>
+    <Files magento_umask>
+            order allow,deny
+            deny from all
+    </Files>
 
 ################################
 ## If running in cluster environment, uncomment this

.htaccess.sample

@@ -274,6 +274,10 @@
         order allow,deny
         deny from all
     </Files>
+    <Files magento_umask>
+        order allow,deny
+        deny from all
+    </Files>
 
 ################################
 ## If running in cluster environment, uncomment this

app/bootstrap.php

@@ -10,10 +10,6 @@
 error_reporting(E_ALL);
 #ini_set('display_errors', 1);
 
-/* Custom umask value may be provided in MAGE_UMASK environment variable */
-$mask = isset($_SERVER['MAGE_UMASK']) ? octdec($_SERVER['MAGE_UMASK']) : 002;
-umask($mask);
-
 /* PHP version validation */
 if (!defined('PHP_VERSION_ID') || PHP_VERSION_ID < 50522) {
     if (PHP_SAPI == 'cli') {
@@ -31,6 +27,11 @@
     exit(1);
 }
 
+/* Custom umask value may be provided in optional mage_umask file in root */
+$umaskFile = BP . '/magento_umask';
+$mask = file_exists($umaskFile) ? octdec(file_get_contents($umaskFile)) : 002;
+umask($mask);
+
 require_once __DIR__ . '/autoload.php';
 require_once BP . '/app/functions.php';
 

pub/.htaccess

@@ -4,12 +4,6 @@
 
 #   SetEnv MAGE_MODE default # or production or developer
 
-############################################
-## Overrides default umask value to allow using different
-## file permissions
-
-#   SetEnv MAGE_UMASK 022
-
 ############################################
 ## Uncomment these lines for CGI mode.
 ## Make sure to specify the correct cgi php binary file name