MAGETWO-87838: Show maintenance IP-address without commas magento#13587

Oleksii Korshenko · web-flow · commit 915f7c1efff8 · 2018-02-15T15:13:22.000-06:00
diff --git a/setup/src/Magento/Setup/Console/Command/MaintenanceAllowIpsCommand.php b/setup/src/Magento/Setup/Console/Command/MaintenanceAllowIpsCommand.php
@@ -93,7 +93,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             if (!empty($addresses)) {
                 $this->maintenanceMode->setAddresses(implode(',', $addresses));
                 $output->writeln(
-                    '<info>Set exempt IP-addresses: ' . implode(', ', $this->maintenanceMode->getAddressInfo()) .
+                    '<info>Set exempt IP-addresses: ' . implode(' ', $this->maintenanceMode->getAddressInfo()) .
                     '</info>'
                 );
             }
diff --git a/setup/src/Magento/Setup/Console/Command/MaintenanceStatusCommand.php b/setup/src/Magento/Setup/Console/Command/MaintenanceStatusCommand.php
@@ -54,7 +54,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             ($this->maintenanceMode->isOn() ? 'active' : 'not active') . '</info>'
         );
         $addressInfo = $this->maintenanceMode->getAddressInfo();
-        $addresses = implode(', ', $addressInfo);
+        $addresses = implode(' ', $addressInfo);
         $output->writeln('<info>List of exempt IP-addresses: ' . ($addresses ? $addresses : 'none') . '</info>');
     }
 }
diff --git a/setup/src/Magento/Setup/Test/Unit/Console/Command/MaintenanceAllowIpsCommandTest.php b/setup/src/Magento/Setup/Test/Unit/Console/Command/MaintenanceAllowIpsCommandTest.php
@@ -75,7 +75,7 @@ public function executeDataProvider()
             [
                 ['ip' => ['127.0.0.1', '127.0.0.2'], '--none' => false],
                 [],
-                'Set exempt IP-addresses: 127.0.0.1, 127.0.0.2' . PHP_EOL
+                'Set exempt IP-addresses: 127.0.0.1 127.0.0.2' . PHP_EOL
             ],
             [
                 ['--none' => true],
diff --git a/setup/src/Magento/Setup/Test/Unit/Console/Command/MaintenanceStatusCommandTest.php b/setup/src/Magento/Setup/Test/Unit/Console/Command/MaintenanceStatusCommandTest.php
@@ -50,7 +50,7 @@ public function executeDataProvider()
             [
                 [true, ['127.0.0.1', '127.0.0.2']],
                 'Status: maintenance mode is active' . PHP_EOL .
-                'List of exempt IP-addresses: 127.0.0.1, 127.0.0.2' . PHP_EOL
+                'List of exempt IP-addresses: 127.0.0.1 127.0.0.2' . PHP_EOL
             ],
             [
                 [true, []],
@@ -63,7 +63,7 @@ public function executeDataProvider()
             [
                 [false, ['127.0.0.1', '127.0.0.2']],
                 'Status: maintenance mode is not active' . PHP_EOL .
-                'List of exempt IP-addresses: 127.0.0.1, 127.0.0.2' . PHP_EOL
+                'List of exempt IP-addresses: 127.0.0.1 127.0.0.2' . PHP_EOL
             ],
         ];
     }

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`93`	`93`	`if (!empty($addresses)) {`
`94`	`94`	`$this->maintenanceMode->setAddresses(implode(',', $addresses));`
`95`	`95`	`$output->writeln(`
`96`		`- '<info>Set exempt IP-addresses: ' . implode(', ', $this->maintenanceMode->getAddressInfo()) .`
	`96`	`+ '<info>Set exempt IP-addresses: ' . implode(' ', $this->maintenanceMode->getAddressInfo()) .`
`97`	`97`	`'</info>'`
`98`	`98`	`);`
`99`	`99`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`54`	`54`	`($this->maintenanceMode->isOn() ? 'active' : 'not active') . '</info>'`
`55`	`55`	`);`
`56`	`56`	`$addressInfo = $this->maintenanceMode->getAddressInfo();`
`57`		`- $addresses = implode(', ', $addressInfo);`
	`57`	`+ $addresses = implode(' ', $addressInfo);`
`58`	`58`	`$output->writeln('<info>List of exempt IP-addresses: ' . ($addresses ? $addresses : 'none') . '</info>');`
`59`	`59`	`}`
`60`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public function executeDataProvider()`
`75`	`75`	`[`
`76`	`76`	`['ip' => ['127.0.0.1', '127.0.0.2'], '--none' => false],`
`77`	`77`	`[],`
`78`		`- 'Set exempt IP-addresses: 127.0.0.1, 127.0.0.2' . PHP_EOL`
	`78`	`+ 'Set exempt IP-addresses: 127.0.0.1 127.0.0.2' . PHP_EOL`
`79`	`79`	`],`
`80`	`80`	`[`
`81`	`81`	`['--none' => true],`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function executeDataProvider()`
`50`	`50`	`[`
`51`	`51`	`[true, ['127.0.0.1', '127.0.0.2']],`
`52`	`52`	`'Status: maintenance mode is active' . PHP_EOL .`
`53`		`- 'List of exempt IP-addresses: 127.0.0.1, 127.0.0.2' . PHP_EOL`
	`53`	`+ 'List of exempt IP-addresses: 127.0.0.1 127.0.0.2' . PHP_EOL`
`54`	`54`	`],`
`55`	`55`	`[`
`56`	`56`	`[true, []],`
`@@ -63,7 +63,7 @@ public function executeDataProvider()`
`63`	`63`	`[`
`64`	`64`	`[false, ['127.0.0.1', '127.0.0.2']],`
`65`	`65`	`'Status: maintenance mode is not active' . PHP_EOL .`
`66`		`- 'List of exempt IP-addresses: 127.0.0.1, 127.0.0.2' . PHP_EOL`
	`66`	`+ 'List of exempt IP-addresses: 127.0.0.1 127.0.0.2' . PHP_EOL`
`67`	`67`	`],`
`68`	`68`	`];`
`69`	`69`	`}`