- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Quotes by topic / genre #135
Comments
This is exactly what the tags feature was intended for. It probably should have been called "topics" or "categories" instead of tags. I would be in favor of renaming this parameter "topics". However, the real problem is: for this feature to be useful, we need to add meaningful topics to all of the existing quotes. I spent quite a bit of time working on this. But there are still ~ 1,200 quotes that do not have topics/tags. If anyone is interested in working on that -- adding topics to the existing quotes let me know. |
Sign me up 🥳 |
@Gal1leo03
Great! The data is in a public repository, anyone is welcome to contribute. It consists of JSON files that contain the source data for each database collection (quotes, authors, tags). To contribute:
The only way to add tags to existing quotes is by manually editing the
|
Is this still open? Do you need me to get on in this one? @lukePeavey |
I've created a pull request after changing the tags of around 300 quotes, My exams were going on so my schedule was pretty filled up, so I am really really sorry for the delay :) @lukePeavey |
@raxraj which part did you want to work on, adding tags to quotes or renaming the tags param? |
@Gal1leo03 no need to apologize! Thanks for working on that. I'll merge your PR today. |
@lukePeavey Has anything happened related to this issue? |
The api already uses "tags" to categorize and filter quotes. The tags feature is essentially the same concept as "topics" or "categories". So I don't think we need to add a new feature for this. If you want to add /edit tags on existing quotes you can do so via the data repository |
Feature
For Each Quotes, add genre as parameter and we can filter based on it. I can see that tag is also used for same purpose but not exactly the same.
The text was updated successfully, but these errors were encountered: