Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert function of circular-linked-list in charpter6 is error #186

Closed
SHIJIECHN opened this issue Jan 28, 2022 · 6 comments
Closed

Insert function of circular-linked-list in charpter6 is error #186

SHIJIECHN opened this issue Jan 28, 2022 · 6 comments

Comments

@SHIJIECHN
Copy link

circular-linked-list.js
error: current = this.getElementAt(this.size());
answer: current = this.getElementAt(this.size() - 1);

@carlos-novaes
Copy link

circular-linked-list.js error: current = this.getElementAt(this.size()); answer: current = this.getElementAt(this.size() - 1);

it took me almost an hour to figure it out, I'm glad that I wasn't the only one that got it :D

@loiane
Copy link
Owner

loiane commented Mar 24, 2022

@carlos-novaes @SHIJIECHN can you please open a PR with this fix?
Thanks for pointing it out!

@Jeffzholy
Copy link

@loiane don't have an access to push up a branch for opening a PR, how to open a PR correctly?

@loiane
Copy link
Owner

loiane commented May 11, 2022

@Jeffzholy you can fork the project to your github account, create a branch, commit the fix and then create the PR from your fork to this github repo.

@Jeffzholy
Copy link

@loiane #190

@loiane
Copy link
Owner

loiane commented May 11, 2022

@Jeffzholy thank you, merged.

@loiane loiane closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants