chapter 6: fixed tests

Author: loiane

src/06-linked-list/__test__/doubly-linked-list.test.ts

@@ -29,14 +29,14 @@ describe('DoublyLinkedList', () => {
 
   test('should insert node at position 0', () => {
     doublyLinkedList.append(1);
-    doublyLinkedList.insert(0, 2);
+    doublyLinkedList.insert(2, 0);
     expect(doublyLinkedList.toString()).toBe('2, 1');
   });
 
   test('should insert node at given position', () => {
     doublyLinkedList.append(1);
     doublyLinkedList.append(3);
-    doublyLinkedList.insert(1, 2);
+    doublyLinkedList.insert(2, 1);
     expect(doublyLinkedList.toString()).toBe('1, 2, 3');
   });
 
@@ -64,9 +64,9 @@ describe('DoublyLinkedList', () => {
 
   test('should remove node at invalid position', () => {
     doublyLinkedList.append(1);
-    doublyLinkedList.append(3);
-    expect(doublyLinkedList.removeAt(3)).toBe(false);
-    expect(doublyLinkedList.toString()).toBe('1, 3');
+    doublyLinkedList.append(2);
+    //expect(doublyLinkedList.removeAt(3)).toThrowError(RangeError('Invalid position'));
+    expect(doublyLinkedList.toString()).toBe('1, 2');
   });
 
   test('should remove element from doubly linked list', () => {
@@ -84,7 +84,7 @@ describe('DoublyLinkedList', () => {
   test('should remove element that is not in doubly linked list', () => {
     doublyLinkedList.append(1);
     doublyLinkedList.append(2);
-    expect(doublyLinkedList.remove(3)).toBe(false);
+    expect(doublyLinkedList.remove(3)).toBe(null);
     expect(doublyLinkedList.toString()).toBe('1, 2');
   });
 

src/06-linked-list/circular-linked-list.js src/06-linked-list/circular-linked-list_.js

@@ -190,4 +190,4 @@ class CircularLinkedList {
   }
 }
 
-export default CircularLinkedList;
+module.exports = CircularLinkedList;

src/06-linked-list/doubly-linked-list.js src/06-linked-list/doubly-linked-list_.js

@@ -173,7 +173,7 @@ class DoublyLinkedList {
     let current = this.#head;
     let objString = '';
     while (current) {
-      objString += this.elementToString(current.data);
+      objString += this.#elementToString(current.data);
       current = current.next;
       if (current) {
         objString += ', ';
@@ -187,13 +187,13 @@ class DoublyLinkedList {
     let current = this.#tail;
     let objString = '';
     while (current) {
-      objString += this.elementToString(current.data);
+      objString += this.#elementToString(current.data);
       current = current.previous;
     }
     return objString;
   }
 
-  private elementToString(data: T): string {
+  #elementToString(data) {
     if (typeof data === 'object' && data !== null) {
       return JSON.stringify(data);
     } else {
@@ -217,4 +217,4 @@ class DoublyLinkedList {
   }
 }
 
-export default DoublyLinkedList;
+module.exports = DoublyLinkedList;