Skip to content

Commit c77f710

Browse files
authored
simplify default post_create_command.sh (LAION-AI#2970)
I have been trying to use default codespace for testing some PR's and finding it somewhat impossible to use in github codespaces as it seems to be trying to do too much automatically. - we should run as little as possible in the default devcontainer to make it as fast and easy to get going with. - if does not make sense to run the post create scripts of the other devcontainers, their own devcontainer.jsons call those scripts themselves.
1 parent 9563a98 commit c77f710

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

.devcontainer/post_create_command.sh

+3-8
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
#!/bin/bash
22

3-
# Run both backend-dev and frontend-dev post_create scripts
3+
# do as little as possible in this script to keep the container creation fast.
4+
# for more specific devcontainer use cases use the different devcontainer subfolders.
45

5-
./.devcontainer/backend-dev/post_create_command.sh
6-
./.devcontainer/frontend-dev/post_create_command.sh
7-
8-
# run yarn install in docs folder
9-
cd docs
10-
yarn install
11-
cd ..
6+
echo "done"

0 commit comments

Comments
 (0)