Skip to content

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Nov 22, 2024

This PR fix the parsing error when the host ends with : but port is empty, for example:

ssh://git@github.com:/myorg/terraform-infra.git

Note the host github.com ends with : but the port is empty. See issue: linrongbin16/gitlinker.nvim#250.

@github-actions github-actions bot added the fix label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (7e9df17) to head (e456c2a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   95.79%   95.83%   +0.03%     
==========================================
  Files           1        1              
  Lines         214      216       +2     
==========================================
+ Hits          205      207       +2     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@linrongbin16 linrongbin16 changed the title fix(port): fix empty port fix(port): fix host ends with colon but port is empty Nov 22, 2024
@linrongbin16 linrongbin16 merged commit a2d473a into main Nov 22, 2024
10 checks passed
@linrongbin16 linrongbin16 deleted the fix-host branch November 22, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant