treewide: remove unless void cast on unused function arguments

Function arguments that are unused are already specified using
__maybe_unused attribute. Remove the useless remaining cast to void
and replace __maybe_unused with __unused where applicable.

Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

Author: etienne-lms

hello_world/ta/hello_world_ta.c

@@ -57,8 +57,8 @@ void TA_DestroyEntryPoint(void)
  * TA.
  */
 TEE_Result TA_OpenSessionEntryPoint(uint32_t param_types,
-				    TEE_Param __maybe_unused params[4],
-				    void __maybe_unused **sess_ctx)
+				    TEE_Param __unused params[4],
+				    void __unused **sess_ctx)
 {
 	uint32_t exp_param_types = TEE_PARAM_TYPES(TEE_PARAM_TYPE_NONE,
 						   TEE_PARAM_TYPE_NONE,
@@ -70,10 +70,6 @@ TEE_Result TA_OpenSessionEntryPoint(uint32_t param_types,
 	if (param_types != exp_param_types)
 		return TEE_ERROR_BAD_PARAMETERS;
 
-	/* Unused parameters */
-	(void)&params;
-	(void)&sess_ctx;
-
 	/*
 	 * The DMSG() macro is non-standard, TEE Internal API doesn't
 	 * specify any means to logging from a TA.
@@ -88,9 +84,8 @@ TEE_Result TA_OpenSessionEntryPoint(uint32_t param_types,
  * Called when a session is closed, sess_ctx hold the value that was
  * assigned by TA_OpenSessionEntryPoint().
  */
-void TA_CloseSessionEntryPoint(void __maybe_unused *sess_ctx)
+void TA_CloseSessionEntryPoint(void __unused *sess_ctx)
 {
-	(void)&sess_ctx; /* Unused parameter */
 	IMSG("Goodbye!\n");
 }
 
@@ -136,12 +131,10 @@ static TEE_Result dec_value(uint32_t param_types, TEE_Param params[4])
  * assigned by TA_OpenSessionEntryPoint(). The rest of the paramters
  * comes from normal world.
  */
-TEE_Result TA_InvokeCommandEntryPoint(void __maybe_unused *sess_ctx,
+TEE_Result TA_InvokeCommandEntryPoint(void __unused *sess_ctx,
 				      uint32_t cmd_id, uint32_t param_types,
 				      TEE_Param params[4])
 {
-	(void)&sess_ctx; /* Unused parameter */
-
 	switch (cmd_id) {
 	case TA_HELLO_WORLD_CMD_INC_VALUE:
 		return inc_value(param_types, params);

random/ta/random_example_ta.c

@@ -40,8 +40,8 @@ void TA_DestroyEntryPoint(void)
 }
 
 TEE_Result TA_OpenSessionEntryPoint(uint32_t param_types,
-				    TEE_Param __maybe_unused params[4],
-				    void __maybe_unused **sess_ctx)
+				    TEE_Param __unused params[4],
+				    void __unused **sess_ctx)
 {
 	uint32_t exp_param_types = TEE_PARAM_TYPES(TEE_PARAM_TYPE_NONE,
 						   TEE_PARAM_TYPE_NONE,
@@ -50,15 +50,11 @@ TEE_Result TA_OpenSessionEntryPoint(uint32_t param_types,
 	if (param_types != exp_param_types)
 		return TEE_ERROR_BAD_PARAMETERS;
 
-	(void)&params;
-	(void)&sess_ctx;
-
 	return TEE_SUCCESS;
 }
 
-void TA_CloseSessionEntryPoint(void __maybe_unused *sess_ctx)
+void TA_CloseSessionEntryPoint(void __unused *sess_ctx)
 {
-	(void)&sess_ctx;
 }
 
 static TEE_Result random_number_generate(uint32_t param_types,
@@ -94,12 +90,10 @@ static TEE_Result random_number_generate(uint32_t param_types,
 	return TEE_SUCCESS;
 }
 
-TEE_Result TA_InvokeCommandEntryPoint(void __maybe_unused *sess_ctx,
+TEE_Result TA_InvokeCommandEntryPoint(void __unused *sess_ctx,
 				      uint32_t cmd_id, uint32_t param_types,
 				      TEE_Param params[4])
 {
-	(void)&sess_ctx;
-
 	switch (cmd_id) {
 	case TA_RANDOM_CMD_GENERATE:
 		return random_number_generate(param_types, params);