Skip to content

Commit 1790379

Browse files
etienne-lmsjforissier
authored andcommitted
sign_verify: define local variables at block entry
OP-TEE coding style requests local variables to be defined at block entries. Correct sign_verify TA accordingly. Signed-off-by: Etienne Carriere <etienne.carriere@st.com> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
1 parent 0d8497a commit 1790379

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

sign_verify/ta/sign_verify_ta.c

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,11 @@ static TEE_Result sign_verify(uint32_t param_types,
162162
uint32_t sig_alg = 0;
163163
uint32_t algo_num= 0;
164164
uint32_t hash_alg = 0;
165+
size_t msg_len = 0;
166+
size_t out_len = 0;
167+
size_t key_sz = 0;
168+
void *msg = NULL;
169+
void *out = NULL;
165170

166171
if (param_types != exp_param_types)
167172
return TEE_ERROR_BAD_PARAMETERS;
@@ -175,11 +180,11 @@ static TEE_Result sign_verify(uint32_t param_types,
175180
if (hash_alg == 0)
176181
return TEE_ERROR_BAD_PARAMETERS;
177182

178-
void *msg = params[0].memref.buffer;
179-
size_t msg_len = params[0].memref.size;
180-
void *out = params[1].memref.buffer;
181-
size_t out_len = params[1].memref.size;
182-
size_t key_sz = params[3].value.a;
183+
msg = params[0].memref.buffer;
184+
msg_len = params[0].memref.size;
185+
out = params[1].memref.buffer;
186+
out_len = params[1].memref.size;
187+
key_sz = params[3].value.a;
183188

184189
/* Generate Key */
185190
DMSG("Generate Key");

0 commit comments

Comments
 (0)