Attempt at fixing thread deleted notification

Author: driesvints

app/Http/Controllers/Forum/ThreadsController.php

@@ -140,7 +140,7 @@ public function delete(Request $request, Thread $thread): RedirectResponse
 
         $request->whenFilled('reason', function () use ($thread) {
             $thread->author()?->notify(
-                new ThreadDeletedNotification($thread, request('reason')),
+                new ThreadDeletedNotification($thread->subject(), request('reason')),
             );
         });
 

app/Notifications/ThreadDeletedNotification.php

@@ -3,7 +3,6 @@
 namespace App\Notifications;
 
 use App\Mail\ThreadDeletedEmail;
-use App\Models\Thread;
 use App\Models\User;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
@@ -13,7 +12,7 @@ class ThreadDeletedNotification extends Notification implements ShouldQueue
 {
     use Queueable;
 
-    public function __construct(public Thread $thread, public ?string $reason = null) {}
+    public function __construct(public string $threadSubject, public ?string $reason = null) {}
 
     public function via($notifiable): array
     {
@@ -22,7 +21,7 @@ public function via($notifiable): array
 
     public function toMail(User $user): ThreadDeletedEmail
     {
-        return (new ThreadDeletedEmail($this->thread->subject(), $this->reason))
+        return (new ThreadDeletedEmail($this->threadSubject, $this->reason))
             ->to($user->emailAddress(), $user->name());
     }
 }

tests/Feature/SettingsTest.php

@@ -197,7 +197,12 @@
 });
 
 test('website is optional', function () {
-    $user = $this->createUser(['email' => 'freek@example.com', 'username' => 'freekmurze', 'twitter' => 'freektwitter', 'website' => 'https://laravel.io']);
+    $user = $this->createUser([
+        'email' => 'freek@example.com',
+        'username' => 'freekmurze',
+        'twitter' => 'freektwitter',
+        'website' => 'https://freek.dev',
+    ]);
 
     $this->loginAs($user);
 
@@ -212,7 +217,7 @@
         ->assertRedirect('/settings');
 
     $this->followRedirects($response)
-        ->assertDontSee('https://laravel.io');
+        ->assertDontSee('https://freek.dev');
 
     expect($user->fresh()->website())->toBeEmpty();
 });