Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const contexts for literal expressions #5

Closed
MSakamaki opened this issue Feb 6, 2019 · 2 comments
Closed

Add const contexts for literal expressions #5

MSakamaki opened this issue Feb 6, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@MSakamaki
Copy link
Contributor

want you to incorporate features that you think are personally wonderful entering from typescript 3.4

https://github.com/labs42io/clean-code-typescript#avoid-side-effects-part-1

The const definition does not block rewriting of the contents of object, but you can handle immutable objects by using as const.
(It can be experienced with typescript 3.4.0-dev)

microsoft/TypeScript#29510
@dimadeveatii dimadeveatii added the enhancement New feature or request label Feb 6, 2019
@dimadeveatii
Copy link
Member

This is a nice one, didn't know about it.
Let's first wait for it to be in a release and covered with official documentation so that we can reference it.

@MSakamaki MSakamaki mentioned this issue May 30, 2019
Merged
@dimadeveatii
Copy link
Member

Fixed in #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimadeveatii @MSakamaki