@@ -14,24 +14,29 @@ See the License for the specific language governing permissions and
1414limitations under the License.
1515*/
1616
17+ /*
18+ Package conversion provides implementation for CRD conversion webhook that implements handler for version conversion requests for types that are convertible.
19+
20+ See pkg/conversion for interface definitions required to ensure a Type is convertible.
21+ */
1722package conversion
1823
1924import (
2025 "encoding/json"
2126 "fmt"
22- "io/ioutil"
2327 "net/http"
2428
2529 apix "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
2630 "k8s.io/apimachinery/pkg/api/meta"
31+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2732 "k8s.io/apimachinery/pkg/runtime"
2833 "k8s.io/apimachinery/pkg/runtime/schema"
2934 "sigs.k8s.io/controller-runtime/pkg/conversion"
3035 logf "sigs.k8s.io/controller-runtime/pkg/log"
3136)
3237
3338var (
34- log = logf .Log .WithName ("conversion_webhook " )
39+ log = logf .Log .WithName ("conversion-webhook " )
3540)
3641
3742// Webhook implements a CRD conversion webhook HTTP handler.
@@ -49,22 +54,15 @@ func (wh *Webhook) InjectScheme(s *runtime.Scheme) error {
4954 return err
5055 }
5156
52- // inject the decoder here too, just in case the order of calling this is not
53- // scheme first, then inject func
54- // if w.Handler != nil {
55- // if _, err := InjectDecoderInto(w.GetDecoder(), w.Handler); err != nil {
56- // return err
57- // }
58- // }
59-
6057 return nil
6158}
6259
6360// ensure Webhook implements http.Handler
6461var _ http.Handler = & Webhook {}
6562
6663func (wh * Webhook ) ServeHTTP (w http.ResponseWriter , r * http.Request ) {
67- convertReview , err := wh .readRequest (r )
64+ convertReview := & apix.ConversionReview {}
65+ err := json .NewDecoder (r .Body ).Decode (convertReview )
6866 if err != nil {
6967 log .Error (err , "failed to read conversion request" )
7068 w .WriteHeader (http .StatusBadRequest )
@@ -89,28 +87,6 @@ func (wh *Webhook) ServeHTTP(w http.ResponseWriter, r *http.Request) {
8987 }
9088}
9189
92- func (wh * Webhook ) readRequest (r * http.Request ) (* apix.ConversionReview , error ) {
93-
94- var body []byte
95- if r .Body == nil {
96- return nil , fmt .Errorf ("nil request body" )
97- }
98- data , err := ioutil .ReadAll (r .Body )
99- if err != nil {
100- return nil , err
101- }
102- body = data
103-
104- convertReview := & apix.ConversionReview {}
105- // TODO(droot): figure out if we want to split decoder for conversion
106- // request from the objects contained in the request
107- err = wh .decoder .DecodeInto (body , convertReview )
108- if err != nil {
109- return nil , err
110- }
111- return convertReview , nil
112- }
113-
11490// handles a version conversion request.
11591func (wh * Webhook ) handleConvertRequest (req * apix.ConversionRequest ) (* apix.ConversionResponse , error ) {
11692 if req == nil {
@@ -142,58 +118,49 @@ func (wh *Webhook) handleConvertRequest(req *apix.ConversionRequest) (*apix.Conv
142118// convertObject will convert given a src object to dst object.
143119// Note(droot): couldn't find a way to reduce the cyclomatic complexity under 10
144120// without compromising readability, so disabling gocyclo linter
145- // nolint: gocyclo
146121func (wh * Webhook ) convertObject (src , dst runtime.Object ) error {
147122 srcGVK := src .GetObjectKind ().GroupVersionKind ()
148123 dstGVK := dst .GetObjectKind ().GroupVersionKind ()
149124
150- if srcGVK .GroupKind (). String () != dstGVK .GroupKind (). String () {
125+ if srcGVK .GroupKind () != dstGVK .GroupKind () {
151126 return fmt .Errorf ("src %T and dst %T does not belong to same API Group" , src , dst )
152127 }
153128
154- if srcGVK . String () == dstGVK . String () {
129+ if srcGVK == dstGVK {
155130 return fmt .Errorf ("conversion is not allowed between same type %T" , src )
156131 }
157132
158133 srcIsHub , dstIsHub := isHub (src ), isHub (dst )
159134 srcIsConvertible , dstIsConvertible := isConvertible (src ), isConvertible (dst )
160135
161- if srcIsHub {
162- if dstIsConvertible {
163- return dst .(conversion.Convertible ).ConvertFrom (src .(conversion.Hub ))
164- }
136+ switch {
137+ case srcIsHub && dstIsConvertible :
138+ return dst .(conversion.Convertible ).ConvertFrom (src .(conversion.Hub ))
139+ case dstIsHub && srcIsConvertible :
140+ return src .(conversion.Convertible ).ConvertTo (dst .(conversion.Hub ))
141+ case srcIsConvertible && dstIsConvertible :
142+ return wh .convertViaHub (src .(conversion.Convertible ), dst .(conversion.Convertible ))
143+ default :
165144 return fmt .Errorf ("%T is not convertible to %T" , src , dst )
166145 }
146+ }
167147
168- if dstIsHub {
169- if srcIsConvertible {
170- return src .(conversion.Convertible ).ConvertTo (dst .(conversion.Hub ))
171- }
172- return fmt .Errorf ("%T is not convertible %T" , dst , src )
173- }
174-
175- // neither src nor dst are Hub, means both of them are spoke, so lets get the hub
176- // version type.
148+ func (wh * Webhook ) convertViaHub (src , dst conversion.Convertible ) error {
177149 hub , err := wh .getHub (src )
178150 if err != nil {
179151 return err
180152 }
181153
182154 if hub == nil {
183- return fmt .Errorf ("API Group %s does not have any Hub defined" , srcGVK )
155+ return fmt .Errorf ("%s does not have any Hub defined" , src )
184156 }
185157
186- // src and dst needs to be convertable for it to work
187- if ! srcIsConvertible || ! dstIsConvertible {
188- return fmt .Errorf ("%T and %T needs to be convertable" , src , dst )
189- }
190-
191- err = src .(conversion.Convertible ).ConvertTo (hub )
158+ err = src .ConvertTo (hub )
192159 if err != nil {
193160 return fmt .Errorf ("%T failed to convert to hub version %T : %v" , src , hub , err )
194161 }
195162
196- err = dst .(conversion. Convertible ). ConvertFrom (hub )
163+ err = dst .ConvertFrom (hub )
197164 if err != nil {
198165 return fmt .Errorf ("%T failed to convert from hub version %T : %v" , dst , hub , err )
199166 }
@@ -256,3 +223,13 @@ func isConvertible(obj runtime.Object) bool {
256223 _ , yes := obj .(conversion.Convertible )
257224 return yes
258225}
226+
227+ // helper to construct error response.
228+ func errored (err error ) * apix.ConversionResponse {
229+ return & apix.ConversionResponse {
230+ Result : metav1.Status {
231+ Status : metav1 .StatusFailure ,
232+ Message : err .Error (),
233+ },
234+ }
235+ }
0 commit comments