Skip to content

Commit 75a1187

Browse files
authored
✨ chore: Fix bad urls (#1632)
* chore: Fix bad urls Link https://github.com/kubernetes/apiserver/blob/master/pkg/apis/config/v1alpha1/defaults.go is out of date since k8s.io/{apiserver,apimachinery}/pkg/apis/config is moved to k8s.io/component-base/config. * chore: update pull request template
1 parent 5f8befe commit 75a1187

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.github/pull_request_template.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<!-- please add an icon to the title of this PR (see VERSIONING.md), and delete this line and similar ones -->
2-
<!-- the icon will be either ⚠ (:warning:, major), ✨ (:sparkles, minor), 🐛 (:bug:, patch), 📖 (:book:, docs), or 🌱 (:seedling:, other) -->
2+
<!-- the icon will be either ⚠ (:warning:, major), ✨ (:sparkles:, minor), 🐛 (:bug:, patch), 📖 (:book:, docs), or 🌱 (:seedling:, other) -->
33

44
<!-- What does this do, and why do we need it? -->

FAQ.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ to test against a real API server. In our experience, tests using fake
5555
clients gradually re-implement poorly-written impressions of a real API
5656
server, which leads to hard-to-maintain, complex test code.
5757

58-
### Q: How should I write tests? Any suggestions for getting started?
58+
### Q: How should I write tests? Any suggestions for getting started?
5959

6060
- Use the aforementioned
6161
[envtest.Environment](https://godoc.org/sigs.k8s.io/controller-runtime/pkg/envtest#Environment)

example_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ func Example() {
6363
// This example creates a simple application Controller that is configured for ReplicaSets and Pods.
6464
// This application controller will be running leader election with the provided configuration in the manager options.
6565
// If leader election configuration is not provided, controller runs leader election with default values.
66-
// Default values taken from: https://github.com/kubernetes/apiserver/blob/master/pkg/apis/config/v1alpha1/defaults.go
66+
// Default values taken from: https://github.com/kubernetes/component-base/blob/master/config/v1alpha1/defaults.go
6767
// defaultLeaseDuration = 15 * time.Second
6868
// defaultRenewDeadline = 10 * time.Second
6969
// defaultRetryPeriod = 2 * time.Second

pkg/manager/internal.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ import (
4747
)
4848

4949
const (
50-
// Values taken from: https://github.com/kubernetes/apiserver/blob/master/pkg/apis/config/v1alpha1/defaults.go
50+
// Values taken from: https://github.com/kubernetes/component-base/blob/master/config/v1alpha1/defaults.go
5151
defaultLeaseDuration = 15 * time.Second
5252
defaultRenewDeadline = 10 * time.Second
5353
defaultRetryPeriod = 2 * time.Second

0 commit comments

Comments
 (0)